Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Don't log a console error when the story is missing #16783

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

tmeasday
Copy link
Member

It doesn't really add anything and it trips up tools like storyshots.

@yannbf I wasn't actually able to reproduce this problem in Storyshots in any of the internal projects however.

It doesn't really add anything and it trips up tools like storyshots.
@tmeasday tmeasday requested a review from yannbf November 25, 2021 07:25
@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2021

Nx Cloud Report

CI ran the following commands for commit 89c38f7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I see it in the feat/sb-6.4 branch of this project https://github.com/yannbf/mealdrop/blob/77e45fc998e63e5d7d526d0369842a5d4e61c64f/src/storybook-snapshot.test.ts#L5

There must be something wrong I'm doing there

@tmeasday
Copy link
Member Author

I'm happy to merge this anyway, but I'll see if I can figure out what's happening here.

@tmeasday
Copy link
Member Author

tmeasday commented Nov 25, 2021

It's weird, the code (that should log the error) runs in our monorepo tests, it just seems like console.error() is getting swallowed somewhere (as is console.warn(), but console.log() isn't -- any idea why @ndelangen? This is in the monorepo's storyshots tests).

I'm not going to dig deeper into jest configuration here, I say we just merge this @yannbf

@yannbf
Copy link
Member

yannbf commented Nov 25, 2021

It's weird, the code (that should log the error) runs in our monorepo tests, it just seems like console.error() is getting swallowed somewhere (as is console.warn(), but console.log() isn't -- any idea why @ndelangen? This is in the monorepo's storyshots tests).

I'm not going to dig deeper into jest configuration here, I say we just merge this @yannbf

Sounds good! We can merge and investigate later. It's a simple change anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants