-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Run unit tests on more node versions, mac, and windows #16744
Changes from all commits
d5e9404
dcfdeb8
3d64cda
79cc0ab
595ce8a
e65bd0e
24a2535
23383b7
4fca87b
8d13cfe
c8e0eab
2f781b8
2497080
dacc755
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,11 +129,14 @@ describe('A11YPanel', () => { | |
const { getByText } = render(<ThemedA11YPanel />); | ||
const useChannelArgs = mockedApi.useChannel.mock.calls[0][0]; | ||
act(() => useChannelArgs[EVENTS.RESULT](axeResult)); | ||
await waitFor(() => { | ||
expect(getByText(/Tests completed/)).toBeTruthy(); | ||
expect(getByText(/Violations/)).toBeTruthy(); | ||
expect(getByText(/Passes/)).toBeTruthy(); | ||
expect(getByText(/Incomplete/)).toBeTruthy(); | ||
}); | ||
await waitFor( | ||
() => { | ||
expect(getByText(/Tests completed/)).toBeTruthy(); | ||
expect(getByText(/Violations/)).toBeTruthy(); | ||
expect(getByText(/Passes/)).toBeTruthy(); | ||
expect(getByText(/Incomplete/)).toBeTruthy(); | ||
}, | ||
{ timeout: 2000 } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This timeout didn't actually seem to help, this test still fails intermittently. Would love if someone who knows more about the a11y panel could take a look at why. But even so, I think it might be good to merge this even knowing this test is flakey, just so we can get some windows tests running. |
||
); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives us a way to write tests that don't run on windows or only run on windows. There were only a handful of times that I needed this, and maybe there are other ways around it, but it seemed like a useful enough utility that I thought it would be worth adding.