-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
links should navigate in the parent window #1650
Conversation
I found that creating normal `<a target="_blank" href="https://www.google.com">foo</a>` links inside of a story would update the iframe and not actually take the user out to the external link `<base>`tag is supported by all browsers https://stackoverflow.com/a/2656798/1536309 fixes storybookjs#1122
fyi users can temporarily fix with using their own head tags: https://storybook.js.org/configurations/add-custom-head-tags/ |
Good fix! Please update it in |
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 21.14% 21.14%
=======================================
Files 247 247
Lines 5575 5575
Branches 675 663 -12
=======================================
Hits 1179 1179
- Misses 3890 3907 +17
+ Partials 506 489 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can update app/vue
, think we're good to merge. Thanks for fixing!
@danielduan I updated |
Issue:
fixes #1122
What I did
I found that creating normal
<a target="_blank" href="https://www.google.com">foo</a>
links inside of a story would update the iframe and not actually take the user out to the external link<base>
tag is supported by all browsers https://stackoverflow.com/a/2656798/1536309How to test
before:
add a link to a component and click on it.
<a href="https://www.google.com">google</a>
will only update the iframe
after:
link moves on the parent window.