-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in getstorybook
project type detection
#1195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 13.31% 13.31%
=======================================
Files 199 199
Lines 4589 4589
Branches 526 603 +77
=======================================
Hits 611 611
+ Misses 3518 3456 -62
- Partials 460 522 +62
Continue to review full report at Codecov.
|
shilman
changed the title
Fix typo in CLI project detection
Fixed typo in Jun 5, 2017
getstorybook
project type detection
ndelangen
approved these changes
Jun 5, 2017
ndelangen
added
cleanup
Minor cleanup style change that won't show up in release changelog
and removed
in progress
labels
Jun 5, 2017
This was referenced Apr 12, 2021
This was referenced Apr 26, 2021
This was referenced Nov 4, 2022
This was referenced Oct 1, 2023
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1193
What I did
Fix typo
How to test
Did not test. Run
getstorybook
in a project with nodevDependencies
and it will break, as in the issue.