Fix watch for windows directories

storybookjs · Dec 6, 2021 · a4911b9 · a4911b9
1 parent c6f0205
commit a4911b9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/core-server/src/utils/watch-story-specifiers.test.ts b/lib/core-server/src/utils/watch-story-specifiers.test.ts
@@ -79,7 +79,7 @@ describe('watchStorySpecifiers', () => {
     onInvalidate.mockClear();
     await onChange('src/nested', 1234);
     expect(onInvalidate).toHaveBeenCalledWith(specifier, `./src/nested/Button.stories.ts`, false);
-  }, 10000);
+  });
 
   it('watches single file globs', async () => {
     const specifier = normalizeStoriesEntry('../src/nested/Button.stories.mdx', options);

diff --git a/lib/core-server/src/utils/watch-story-specifiers.ts b/lib/core-server/src/utils/watch-story-specifiers.ts
@@ -73,9 +73,14 @@ export function watchStorySpecifiers(
               // because the directoru could already be within the files part (e.g. './x/foo/bar')
               path.basename(specifier.files)
             );
-            const files = await glob(dirGlob);
+            // glob only supports forward slashes
+            const files = await glob(dirGlob.replace(/\\/g, '/'));
+
             files.forEach((filePath) => {
-              const fileImportPath = toImportPath(path.relative(options.workingDir, filePath));
+              const fileImportPath = toImportPath(
+                // use posix path separators even on windows
+                path.relative(options.workingDir, filePath).replace(/\\/g, '/')
+              );
 
               if (specifier.importPathMatcher.exec(fileImportPath)) {
                 onInvalidate(specifier, fileImportPath, removed);