Skip to content

Commit

Permalink
Merge pull request #23407 from storybookjs/fix-new-patch-labels
Browse files Browse the repository at this point in the history
Release tooling: Fix new patch labels
  • Loading branch information
JReinhold authored Jul 11, 2023
2 parents 2162c5b + 08e4f00 commit 1396344
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/release/__tests__/generate-pr-description.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Generate PR Description', () => {
id: 'pr-id-11',
user: 'shilman',
title: 'Another PR `title` for docs',
labels: ['another label', 'documentation', 'patch'],
labels: ['another label', 'documentation', 'patch:yes'],
commit: 'ddd222',
pull: 11,
links: {
Expand Down Expand Up @@ -104,7 +104,7 @@ describe('Generate PR Description', () => {
"- [ ] **🐛 Bug**: Some PR title for a bug [#42](https://github.com/storybookjs/storybook/pull/42) (will also be patched)
- [ ] **✨ Feature Request**: Some PR title for a 'new' feature [#48](https://github.com/storybookjs/storybook/pull/48)
- [ ] **⚠️ Direct commit**: Some title for a "direct commit" [22bb11](https://github.com/storybookjs/storybook/commit/22bb11)
- [ ] **📝 Documentation**: Another PR \`title\` for docs [#11](https://github.com/storybookjs/storybook/pull/11)
- [ ] **📝 Documentation**: Another PR \`title\` for docs [#11](https://github.com/storybookjs/storybook/pull/11) (will also be patched)
- [ ] **❔ Missing Label**: Some PR title with a missing label [#77](https://github.com/storybookjs/storybook/pull/77)"
`);
});
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/utils/get-changes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export const mapToChanges = ({
return;
}
// filter out any entries that are not patches if unpickedPatches is set. this will also filter out direct commits
if (unpickedPatches && !entry.labels?.includes('patch')) {
if (unpickedPatches && !entry.labels?.includes('patch:yes')) {
return;
}
changes.push(entry);
Expand Down

0 comments on commit 1396344

Please sign in to comment.