-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nucleo f413zh variant #1853
Merged
fpistm
merged 2 commits into
stm32duino:main
from
gautierg-st:add_nucleo_f413zh_variant
Oct 28, 2022
Merged
Add nucleo f413zh variant #1853
fpistm
merged 2 commits into
stm32duino:main
from
gautierg-st:add_nucleo_f413zh_variant
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Oct 27, 2022
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.cpp
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.h
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.h
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.h
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.cpp
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.cpp
Outdated
Show resolved
Hide resolved
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.cpp
Show resolved
Hide resolved
gautierg-st
force-pushed
the
add_nucleo_f413zh_variant
branch
from
October 27, 2022 11:49
055eccc
to
0bd4eaa
Compare
fpistm
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus fix astyle issue.
variants/STM32F4xx/F413Z(G-H)(J-T)_F423ZH(J-T)/variant_NUCLEO_F413ZH.h
Outdated
Show resolved
Hide resolved
Replace HSE by HSI as the generic clock for the STM32F413Z series
Tested: - Serial - SPI - USB
gautierg-st
force-pushed
the
add_nucleo_f413zh_variant
branch
from
October 28, 2022 08:51
0bd4eaa
to
162dffe
Compare
fpistm
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @gautierg-st
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Nucleo F413ZH board
Tested:
Fixes #1850