Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic_clock.c #1848

Closed
wants to merge 1 commit into from
Closed

Update generic_clock.c #1848

wants to merge 1 commit into from

Conversation

pawkon
Copy link

@pawkon pawkon commented Oct 19, 2022

Proper clock definition 96MHz and RCC_HSE_ON based on STM32CubeIDE

As discussed here: https://www.stm32duino.com/viewtopic.php?p=10988#p10988

Proper clock definition 96MHz
@fpistm
Copy link
Member

fpistm commented Oct 20, 2022

Hi @pawkon
Thanks for the PR. Anyway as it is the generic clock config, it should use the internal clock instead of HSE.
Don't know why it is not the case before, probably a wrong copy paste. All generic provide a default clock config with HSI or MSI.
I guess the Nucleo F413ZH should be added with HSE usage.

@pawkon
Copy link
Author

pawkon commented Oct 20, 2022

It is also possible to use :

RCC_OscInitStruct.HSEState = RCC_HSE_BYPASS;

But with other changes that I've made. It seams that mainly PLLM, PLLN, PLLP, PLLQ, PLLR were wrong

As mentioned here: https://community.st.com/s/question/0D50X0000BYoP9mSQF/which-clock-source-to-use-hsi-or-hse and here https://community.st.com/s/question/0D50X00009Xke7HSAR/hse-versus-hsi-on-nucleo-boards It is better to use HSE which is more accurate for high speed transmissions and despite of temperature. This is why I choose HSE instead HSI

@fpistm fpistm added the abandoned No more work on this label Oct 21, 2022
@fpistm
Copy link
Member

fpistm commented Oct 21, 2022

Hi @pawkon
Again thanks for the PR. @gautierg-st will fix the generic clock and add the support of the Nucleo F413ZH. Fortunately we have one boards and will be able to test.

@fpistm fpistm closed this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned No more work on this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants