Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #808

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

theKnightsOfRohan
Copy link
Contributor

Fixes the two build error messages given in Issue #800 by adding a param outline to the withKeepStrings() and withMaxNestingStrings() method documentation.

@stleary stleary changed the title Fix compiler warnings (Issue #800) Fix compiler warnings Oct 17, 2023
@stleary
Copy link
Owner

stleary commented Oct 17, 2023

What problem does this code solve?
Fixes compiler warnings due to some missing JavaDoc lines

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit 7a85b51 into stleary:master Oct 20, 2023
5 checks passed
@theKnightsOfRohan theKnightsOfRohan deleted the fix-build-messages branch October 23, 2023 15:14
@theKnightsOfRohan theKnightsOfRohan restored the fix-build-messages branch October 23, 2023 16:54
@theKnightsOfRohan theKnightsOfRohan deleted the fix-build-messages branch November 1, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants