Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifies BigDecimal support does not have a regression #532

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

johnjaylward
Copy link
Contributor

@johnjaylward johnjaylward commented Jun 25, 2020

Fixes #531
Add test result to confirm that #531 is working in latest version. No code changes needed.

A new release should be scheduled so the fix can be used by people using the MAVEN artifacts.

Add test result to confirm that stleary#531 is working in latest version.
@johnjaylward johnjaylward changed the title fixes #531 Verifies BigDecimal support does not have a regression Jun 25, 2020
@johnjaylward johnjaylward force-pushed the CheckBigDecimalSupport branch from 4542546 to f9908a6 Compare June 25, 2020 15:52
@stleary
Copy link
Owner

stleary commented Jun 25, 2020

What problem does this code solve?
There was a question about whether BigDecimal support had introduced an unexpected regression. Added unit tests to confirm this was not the case.

Risks
None

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED
No comment window is necessary in this case.

@stleary stleary merged commit 6ddaa13 into stleary:master Jun 25, 2020
This was referenced Mar 10, 2021
@johnjaylward johnjaylward deleted the CheckBigDecimalSupport branch August 28, 2023 16:20
@johnjaylward johnjaylward restored the CheckBigDecimalSupport branch August 28, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONObject.objectToBigDecimal precision errors when parsing doubles
2 participants