Connect command on exising TCP connection #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made preparing separate states because we might prepare multiple times if |
|
I'm considering not containing the connecting part in |
|
Oh gotcha, now I understand the Removing the |
|
I believe this was postponed by #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open to any suggestions. I'm not totally happy with the
connect_existingname.I moved the calls to
prepare_send_*into the state where the data is sent. This made it easier to jump into the state machine after the initial TCP connection is established and I think it better matches what I expect to happen. But I could be missing why it was set up the way it was.