replace failure with thiserror #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consensus seems to be that using failure in libraries is discouraged in in favor of using the std Error trait. thiserror provides the failure features used in tokio-socks while creating an error conforming to the std Error trait. It requires a minimum rustc version of 1.31, but the same is true for failure, so this should not be trouble.
sticnarf
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consensus seems to be that using failure in libraries is discouraged in
in favor of using the std Error trait.
thiserror provides the failure features used in tokio-socks while
creating an error conforming to the std Error trait.
It requires a minimum rustc version of 1.31, but the same is true for
failure, so this should not be trouble.
For people relying on the fact that
tokio_socks::ErrorisFailthis would probably be a breaking change, but I am not sure it would be hard to fix.