Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectFuture buffer too small #1

Closed
dgllghr opened this issue Apr 30, 2019 · 1 comment · Fixed by #2
Closed

ConnectFuture buffer too small #1

dgllghr opened this issue Apr 30, 2019 · 1 comment · Fixed by #2

Comments

@dgllghr
Copy link

dgllghr commented Apr 30, 2019

ConnectFuture has a buffer size that is too small for username/password authentication. The username and password can each be up to 255 bytes and are written as part of the same message, but the buffer is only 262 bytes. I believe the buffer must be 513 bytes to account for the username + password + ver + ulen + plen
@dgllghr dgllghr mentioned this issue Apr 30, 2019
Merged
@sticnarf sticnarf mentioned this issue Apr 30, 2019
Merged
@sticnarf
Copy link
Owner

Version 0.1.2 released with this bug fixed.

sticnarf pushed a commit that referenced this issue Jun 18, 2024
@RoKu1
Merge pull request #1 from RoKu1/reorganize_code_separate_modules
376c37c 
Separated modules for socks4 and socks5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase buf size to account for username password auth message length dgllghr/tokio-socks
2 participants
@dgllghr @sticnarf