Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'comment' field for API keys #536

Closed
raboof opened this issue Jan 11, 2024 · 2 comments · Fixed by #537
Closed

Add 'comment' field for API keys #536

raboof opened this issue Jan 11, 2024 · 2 comments · Fixed by #537

Comments

@raboof
Copy link
Contributor

raboof commented Jan 11, 2024

To remember for what purpose you generated an API key, it would be helpful to store a comment/name/description field.

nscuro added a commit to nscuro/Alpine that referenced this issue Jan 11, 2024
In order to avoid introducing additional latency to requests, API key usage is buffered in-memory and asynchronously flushed to the database in intervals of 30s.

An API key counts as "used" if authentication with it succeeds.

Also, add support for an optional comment for API keys, as requested in stevespringett#536.

Closes stevespringett#362
Closes stevespringett#536

Signed-off-by: nscuro <[email protected]>
@nscuro
Copy link
Collaborator

nscuro commented Jan 11, 2024

Duplicate of #430.

@raboof
Copy link
Contributor Author

raboof commented Jan 12, 2024

doh, indeed, didn't find that one when I searched :/

@raboof raboof closed this as completed Jan 12, 2024
nscuro added a commit to nscuro/Alpine that referenced this issue Jan 12, 2024
In order to avoid introducing additional latency to requests, API key usage is buffered in-memory and asynchronously flushed to the database in intervals of 30s.

An API key counts as "used" if authentication with it succeeds.

Also, add support for an optional comment for API keys, as requested in stevespringett#430 and stevespringett#536.

Closes stevespringett#362
Closes stevespringett#430
Closes stevespringett#536

Signed-off-by: nscuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants