Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency calculation optimization #900

Closed
davidzeng0 opened this issue Aug 12, 2023 · 5 comments · Fixed by #901
Closed

dependency calculation optimization #900

davidzeng0 opened this issue Aug 12, 2023 · 5 comments · Fixed by #901
Labels
released

Comments

@davidzeng0
Copy link
Contributor

In plugin.ts, there should probably be a check that exits if the file is already in the fileSet.
image
@stephenh
Copy link
Owner

Hi @davidzeng0 ; sure, I can add that--out of curiosity, do you have a sufficient number of request.fileToGenerates / file.dependencys that this check would demonstrably change the runtime?

stephenh added a commit that referenced this issue Aug 12, 2023
@stephenh
fix: Only check file dependencies once/file.
758ed79 
Fixes #900
@stephenh stephenh mentioned this issue Aug 12, 2023
Merged
@davidzeng0
Copy link
Contributor Author

Yes, I have ~7k files to generate and the difference is 3 seconds of runtime vs DNF

stephenh added a commit that referenced this issue Aug 13, 2023
@stephenh
fix: Only check file dependencies once/file. (#901)
8d61980 
Fixes #900
@stephenh
Copy link
Owner

Wow. That's a lot of files. :-)

stephenh pushed a commit that referenced this issue Aug 13, 2023
@semantic-release-bot
chore(release): 1.156.3 [skip ci]
2639818 
## [1.156.3](v1.156.2...v1.156.3) (2023-08-13)

### Bug Fixes

* Only check file dependencies once/file. ([#901](#901)) ([8d61980](8d61980)), closes [#900](#900)
@stephenh
Copy link
Owner

🎉 This issue has been resolved in version 1.156.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidzeng0
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Only check file dependencies once/file. stephenh/ts-proto
2 participants
@stephenh @davidzeng0