-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use Map for int64 keys #708
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
Hey @zhuscat ; thanks for the report. That's a good find. We already have some code that will use a JS map, which is enabled with:
It would probably be a good idea to always use the map type for longs, even if If you'd like to submit a PR for that fix, that'd be great! Otherwise just using |
stephenh
changed the title
map<int64, int64> generated to { [key: Long]: Long }, which is a type error
Always use Map for int64 keys
Nov 25, 2022
stephenh
added
bug
Something isn't working
help wanted
Extra attention is needed
good first issue
Good for newcomers
labels
Nov 25, 2022
buzap
added a commit
to buzap/ts-proto
that referenced
this issue
Aug 17, 2023
stephenh
pushed a commit
that referenced
this issue
Aug 18, 2023
eladhaim
pushed a commit
to eladhaim/ts-proto
that referenced
this issue
Sep 2, 2023
* fix: always use Map for int64 keys (stephenh#708) * build: change prettier trailingComma to all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
is generated to
when
--ts_proto_opt=forceLong=long
This is a type error:
The text was updated successfully, but these errors were encountered: