Fix dotnet#68 - filter out type initializer from Type.GetConstructor …

…portable implementation
stephen-swensen · Feb 16, 2015 · df0c8c9 · df0c8c9
1 parent 35e6a00
commit df0c8c9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Quotations/FSharpQuotations.fs b/src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Quotations/FSharpQuotations.fs
@@ -67,3 +67,7 @@ type FSharpQuotationsTests() =
                 let wrongValue = <@ "!" @>
                 Check.argumentException(fun () -> ExprShape.RebuildShapeCombination(shape, [wrongValue;lambda]))
         |   _ -> Assert.Fail()
+
+    [<Test>]
+    member x.GetConstructorFiltersOutStaticConstructor() =
+        ignore <@ System.Exception() @>
diff --git a/src/fsharp/FSharp.Core/reflect.fs b/src/fsharp/FSharp.Core/reflect.fs
@@ -125,9 +125,12 @@ module ReflectionAdapters =
         member this.GetConstructor(parameterTypes : Type[]) = 
             this.GetTypeInfo().DeclaredConstructors
             |> Seq.filter (fun ci ->
-                let parameters = ci.GetParameters()
-                (parameters.Length = parameterTypes.Length) &&
-                (parameterTypes, parameters) ||> Array.forall2 (fun ty pi -> pi.ParameterType.Equals ty) 
+                not ci.IsStatic && //exclude type initializer
+                (
+                    let parameters = ci.GetParameters()
+                    (parameters.Length = parameterTypes.Length) &&
+                    (parameterTypes, parameters) ||> Array.forall2 (fun ty pi -> pi.ParameterType.Equals ty) 
+                )
             )
             |> Seq.toArray
             |> commit