Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text input is broken for Korean, Chinese, Japanese characters #4829

Closed
lukaszfryc opened this issue Jun 19, 2018 · 2 comments · Fixed by #4837
Closed

Text input is broken for Korean, Chinese, Japanese characters #4829

lukaszfryc opened this issue Jun 19, 2018 · 2 comments · Fixed by #4837
Assignees
@mandrigin
Labels
ios

Comments

@lukaszfryc
Copy link
Contributor

Description

Type: Bug

Summary: With recent react-native upgrade we introduced a bug with Chinese characters not being displayed correctly in chat input. The bug occurs only on iOS.

Expected behavior

Users can use Korean, Chinese, Japanese keyboards in Status

Actual behavior

Users can't use Korean, Chinese, Japanese keyboards in Status due to facebook/react-native#19339

Reproduction

  • Switch to a Chinese keyboard on iOS
  • Open Status
  • Send messages in Chinese in a chat

Additional Information

  • Status version: 0.9.20
  • Worked in 0.9.19
  • Operating System: iOS
@lukaszfryc lukaszfryc mentioned this issue Jun 19, 2018
Closed
@mandrigin mandrigin self-assigned this Jun 19, 2018
@pedropombeiro pedropombeiro mentioned this issue Jun 19, 2018
Closed
@mandrigin
Copy link
Contributor

Tried to fix upstream too: facebook/react-native#19809

@mandrigin mandrigin mentioned this issue Jun 20, 2018
Merged
mandrigin added a commit that referenced this issue Jun 20, 2018
@mandrigin
[#4829] Add a patch that fixes complex input on iOS in RN 0.55.x.
caba84e 
The fix is described here: facebook/react-native#19809

The patch:
1. A copy of patched RCTUITextView.m file
2. A pre-action in the "Build" scheme to patch the RN file. See more on
   pre-actions here: https://burcugeneci.wordpress.com/2016/05/25/scripts-we-love-xcode-builds-life-savers/
3. A build step to fail the build if the file wasn't patched.

Signed-off-by: Igor Mandrigin <[email protected]>
@annadanchenko annadanchenko mentioned this issue Jun 20, 2018
Closed
@NamITUTC
Copy link

change onChangeText(text=>) =>onKeyPress(text=>)

@hetvart hetvart mentioned this issue Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandrigin mandrigin

Labels
ios
Projects
None yet
Milestone
No milestone
5 participants
@pedropombeiro @mandrigin @annadanchenko @lukaszfryc @NamITUTC