test_: unskip test initialize logging #6229
Merged
+83
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
qfrank,
antdanchenko,
fbarbu15 and
osmaczko
Jenkins BuildsClick to see older builds (48)
|
|
@fbarbu15 ~~Can you please check, why there's no python linter check? 🤔 ~~ Oh it's wrong target branch, how was I reviewing 🤦 . Fixed here: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6229 +/- ##
===========================================
+ Coverage 61.40% 61.43% +0.02%
===========================================
Files 834 834
Lines 109919 109925 +6
===========================================
+ Hits 67495 67528 +33
+ Misses 34528 34500 -28
- Partials 7896 7897 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Dec 19, 2024
fbarbu15
approved these changes
Dec 19, 2024
qfrank
approved these changes
Dec 19, 2024
antdanchenko
approved these changes
Dec 19, 2024
igor-sirotin
force-pushed
the
test/unskip-TestInitializeLogging
branch
from
dfeecfc to
b862e51
Compare
igor-sirotin
force-pushed
the
test/unskip-TestInitializeLogging
branch
from
b862e51 to
e00505f
Compare
igor-sirotin
force-pushed
the
test/unskip-TestInitializeLogging
branch
from
d1b7978 to
5582113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_statusgo_datathat copies requested data fromstatus-backendcontainer to a temporary host path.TestInitializeLoggingand updated it to useload_statusgo_datastatus-gowill no automatically createDataDirandLogsDir(if they don't exist) duringInitializeApplication.project_name, otherwise it failed when 2 backends are started within 1 second.