feat_: status-backend health endpoint #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (26)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6201 +/- ##
========================================
Coverage 61.41% 61.42%
========================================
Files 833 834 +1
Lines 109925 109934 +9
========================================
+ Hits 67511 67526 +15
- Misses 34518 34522 +4
+ Partials 7896 7886 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Dec 12, 2024
antdanchenko
approved these changes
Dec 12, 2024
igor-sirotin
force-pushed
the
feat/status-backend-healthcheck
branch
from
663c482 to
a97309c
Compare
|
@antdanchenko please take another look, I added |
igor-sirotin
commented
Dec 13, 2024
Comment on lines
26
to
27
| backend_client.verify_json_schema( | ||
| backend_client.wait_for_login(), "signal_node_login") |
There was a problem hiding this comment.
It's better to check login first, because it properly processes results of restore_account_and_login in case of an error. While other signals are just never sent in case of an error.
igor-sirotin
force-pushed
the
feat/status-backend-healthcheck
branch
from
c4a7191 to
bc8398d
Compare
antdanchenko
approved these changes
Dec 17, 2024
igor-sirotin
force-pushed
the
feat/status-backend-healthcheck
branch
from
bc8398d to
af757a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status-backendAt first I brought back docker healthcheck feature, but it didn't make sense. Even having it running in background, we wouldn't get notified and stop the tests. And it wouldn't work when running
status-backendlocally not in docker.At the same time all tests have timeout for all requests.