Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telem)_: track raw message by type on send #6176

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adklempner
Copy link
Contributor

@adklempner adklempner commented Dec 6, 2024

Sends raw message type and payload size to telemetry before sending a message using sender or data sync

Adds a reference to telemetry service to message sender
If telemetry is enabled, metric is sent anytime transport.Track or s.addToDataSync is called in message_sender
Also sent in messenger upon sendDataSync

Important changes:

Closes #

@status-im-auto
Copy link
Member

status-im-auto commented Dec 6, 2024

Jenkins Builds

Click to see older builds (150)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d0ac2e3 #1 2024-12-06 00:49:43 ~5 min linux 📦zip
✔️ d0ac2e3 #1 2024-12-06 00:49:58 ~5 min android 📦aar
✔️ d0ac2e3 #1 2024-12-06 00:50:27 ~5 min tests-rpc 📄log
✔️ d0ac2e3 #1 2024-12-06 00:50:38 ~6 min ios 📦zip
✔️ d0ac2e3 #1 2024-12-06 00:50:39 ~5 min windows 📦zip
✔️ d0ac2e3 #1 2024-12-06 00:51:18 ~6 min macos 📦zip
✔️ d0ac2e3 #1 2024-12-06 00:53:05 ~8 min macos 📦zip
✖️ d0ac2e3 #1 2024-12-06 01:15:36 ~30 min tests 📄log
✔️ 76e8d11 #2 2024-12-06 20:01:25 ~4 min windows 📦zip
✔️ 76e8d11 #2 2024-12-06 20:02:20 ~5 min linux 📦zip
✔️ 76e8d11 #2 2024-12-06 20:02:35 ~5 min android 📦aar
✔️ 76e8d11 #2 2024-12-06 20:02:56 ~6 min tests-rpc 📄log
✔️ 76e8d11 #2 2024-12-06 20:04:07 ~7 min ios 📦zip
✔️ 76e8d11 #2 2024-12-06 20:04:54 ~8 min macos 📦zip
✔️ 76e8d11 #2 2024-12-06 20:08:14 ~11 min macos 📦zip
✖️ 76e8d11 #2 2024-12-06 20:27:41 ~30 min tests 📄log
✔️ 9009d00 #3 2024-12-08 03:24:46 ~4 min windows 📦zip
✔️ 9009d00 #3 2024-12-08 03:25:21 ~5 min linux 📦zip
✔️ 9009d00 #3 2024-12-08 03:25:54 ~5 min android 📦aar
✔️ 9009d00 #3 2024-12-08 03:26:43 ~6 min tests-rpc 📄log
✔️ 9009d00 #3 2024-12-08 03:26:57 ~6 min ios 📦zip
✔️ 9009d00 #3 2024-12-08 03:29:42 ~9 min macos 📦zip
✔️ 9009d00 #3 2024-12-08 03:31:40 ~11 min macos 📦zip
✔️ 9009d00 #3 2024-12-08 03:50:24 ~30 min tests 📄log
✔️ 055bb1d #4 2024-12-08 04:42:28 ~4 min windows 📦zip
✔️ 055bb1d #4 2024-12-08 04:43:20 ~5 min linux 📦zip
✔️ 055bb1d #4 2024-12-08 04:43:25 ~5 min android 📦aar
✔️ 055bb1d #4 2024-12-08 04:44:08 ~6 min ios 📦zip
✔️ 055bb1d #4 2024-12-08 04:44:15 ~6 min tests-rpc 📄log
✔️ 055bb1d #4 2024-12-08 04:47:17 ~9 min macos 📦zip
✔️ 055bb1d #4 2024-12-08 04:47:56 ~9 min macos 📦zip
✖️ 055bb1d #4 2024-12-08 05:07:38 ~29 min tests 📄log
✔️ c4644e7 #5 2024-12-09 22:49:40 ~4 min windows 📦zip
✔️ c4644e7 #5 2024-12-09 22:50:17 ~4 min linux 📦zip
✔️ c4644e7 #5 2024-12-09 22:50:39 ~5 min android 📦aar
✔️ c4644e7 #5 2024-12-09 22:51:26 ~6 min tests-rpc 📄log
✔️ c4644e7 #5 2024-12-09 22:51:47 ~6 min ios 📦zip
✔️ c4644e7 #5 2024-12-09 22:53:27 ~8 min macos 📦zip
✔️ c4644e7 #5 2024-12-09 22:54:47 ~9 min macos 📦zip
✖️ c4644e7 #5 2024-12-09 23:15:06 ~29 min tests 📄log
✔️ c4644e7 #6 2024-12-10 00:29:49 ~27 min tests 📄log
✔️ 4575a71 #6 2024-12-10 20:54:18 ~4 min windows 📦zip
✔️ 4575a71 #6 2024-12-10 20:54:45 ~4 min linux 📦zip
✔️ 4575a71 #6 2024-12-10 20:55:12 ~5 min android 📦aar
✔️ 4575a71 #6 2024-12-10 20:55:40 ~5 min tests-rpc 📄log
✔️ 4575a71 #6 2024-12-10 20:56:48 ~7 min ios 📦zip
✔️ 4575a71 #6 2024-12-10 20:58:14 ~8 min macos 📦zip
✔️ 4575a71 #6 2024-12-10 20:59:51 ~10 min macos 📦zip
✔️ 4575a71 #7 2024-12-10 21:19:12 ~29 min tests 📄log
✔️ e74e115 #7 2024-12-11 01:24:39 ~4 min windows 📦zip
✔️ e74e115 #7 2024-12-11 01:25:25 ~5 min linux 📦zip
✔️ e74e115 #7 2024-12-11 01:25:50 ~5 min android 📦aar
✔️ e74e115 #7 2024-12-11 01:26:20 ~6 min ios 📦zip
✖️ e74e115 #7 2024-12-11 01:26:21 ~5 min tests-rpc 📄log
✔️ e74e115 #7 2024-12-11 01:28:25 ~8 min macos 📦zip
✔️ e74e115 #7 2024-12-11 01:30:58 ~10 min macos 📦zip
✖️ e74e115 #8 2024-12-11 01:49:48 ~29 min tests 📄log
✖️ 8e26853 #9 2024-12-11 05:01:08 ~3 min tests 📄log
✔️ 8e26853 #8 2024-12-11 05:02:03 ~4 min windows 📦zip
✔️ 8e26853 #8 2024-12-11 05:02:59 ~5 min linux 📦zip
✔️ 8e26853 #8 2024-12-11 05:03:18 ~5 min android 📦aar
✖️ 8e26853 #8 2024-12-11 05:04:09 ~6 min tests-rpc 📄log
✔️ 8e26853 #8 2024-12-11 05:05:05 ~7 min ios 📦zip
✔️ 8e26853 #8 2024-12-11 05:07:11 ~9 min macos 📦zip
✔️ 8e26853 #8 2024-12-11 05:10:53 ~13 min macos 📦zip
✔️ ce09e08 #9 2024-12-11 22:29:40 ~4 min macos 📦zip
✔️ ce09e08 #9 2024-12-11 22:29:47 ~4 min ios 📦zip
✔️ ce09e08 #9 2024-12-11 22:29:53 ~4 min windows 📦zip
✔️ ce09e08 #9 2024-12-11 22:30:17 ~5 min linux 📦zip
✔️ ce09e08 #9 2024-12-11 22:30:38 ~5 min android 📦aar
✖️ ce09e08 #9 2024-12-11 22:31:00 ~5 min tests-rpc 📄log
✔️ ce09e08 #9 2024-12-11 22:35:11 ~9 min macos 📦zip
✖️ ce09e08 #10 2024-12-11 22:54:52 ~29 min tests 📄log
✔️ 1787dae #10 2024-12-11 23:11:43 ~4 min windows 📦zip
✔️ 1787dae #10 2024-12-11 23:12:37 ~5 min ios 📦zip
✔️ 1787dae #10 2024-12-11 23:12:51 ~5 min macos 📦zip
✔️ 1787dae #10 2024-12-11 23:13:38 ~6 min android 📦aar
✔️ 1787dae #10 2024-12-11 23:13:42 ~6 min linux 📦zip
✔️ 1787dae #10 2024-12-11 23:13:47 ~6 min tests-rpc 📄log
✔️ 1787dae #10 2024-12-11 23:15:54 ~8 min macos 📦zip
✖️ 1787dae #11 2024-12-11 23:37:01 ~29 min tests 📄log
✔️ 81f0d97 #11 2024-12-12 00:20:43 ~4 min windows 📦zip
✔️ 81f0d97 #11 2024-12-12 00:21:27 ~5 min linux 📦zip
✔️ 81f0d97 #11 2024-12-12 00:21:41 ~5 min android 📦aar
✔️ 81f0d97 #11 2024-12-12 00:21:46 ~5 min ios 📦zip
✔️ 81f0d97 #11 2024-12-12 00:21:52 ~5 min macos 📦zip
✔️ 81f0d97 #11 2024-12-12 00:23:06 ~6 min tests-rpc 📄log
✔️ 81f0d97 #11 2024-12-12 00:25:16 ~8 min macos 📦zip
✔️ 81f0d97 #12 2024-12-12 00:46:51 ~30 min tests 📄log
✔️ d528a0a #12 2024-12-12 02:11:29 ~4 min windows 📦zip
✔️ d528a0a #12 2024-12-12 02:12:14 ~5 min ios 📦zip
✔️ d528a0a #12 2024-12-12 02:12:16 ~5 min linux 📦zip
✔️ d528a0a #12 2024-12-12 02:12:35 ~5 min android 📦aar
✔️ d528a0a #12 2024-12-12 02:12:40 ~5 min macos 📦zip
✖️ d528a0a #12 2024-12-12 02:13:02 ~5 min tests-rpc 📄log
✔️ d528a0a #12 2024-12-12 02:15:35 ~8 min macos 📦zip
✔️ d528a0a #13 2024-12-12 02:37:40 ~30 min tests 📄log
✔️ d9fb920 #13 2024-12-12 22:27:01 ~4 min windows 📦zip
✔️ d9fb920 #13 2024-12-12 22:27:08 ~4 min macos 📦zip
✔️ d9fb920 #13 2024-12-12 22:27:12 ~4 min ios 📦zip
✔️ d9fb920 #13 2024-12-12 22:27:39 ~4 min linux 📦zip
✔️ d9fb920 #13 2024-12-12 22:28:04 ~5 min android 📦aar
✖️ d9fb920 #13 2024-12-12 22:28:33 ~5 min tests-rpc 📄log
✔️ d9fb920 #13 2024-12-12 22:32:47 ~10 min macos 📦zip
✖️ d9fb920 #14 2024-12-12 22:52:06 ~29 min tests 📄log
✖️ d9fb920 #15 2024-12-12 23:27:06 ~27 min tests 📄log
✔️ b89e2a6 #14 2024-12-12 23:44:37 ~4 min windows 📦zip
✔️ b89e2a6 #14 2024-12-12 23:44:53 ~4 min macos 📦zip
✔️ b89e2a6 #14 2024-12-12 23:44:54 ~4 min ios 📦zip
✔️ b89e2a6 #14 2024-12-12 23:45:38 ~5 min linux 📦zip
✔️ b89e2a6 #14 2024-12-12 23:45:49 ~5 min android 📦aar
✔️ b89e2a6 #14 2024-12-12 23:46:33 ~6 min tests-rpc 📄log
✔️ b89e2a6 #14 2024-12-12 23:49:50 ~9 min macos 📦zip
✔️ b89e2a6 #16 2024-12-13 00:09:51 ~29 min tests 📄log
✔️ d94dea8 #15 2024-12-13 01:21:51 ~4 min windows 📦zip
✔️ d94dea8 #15 2024-12-13 01:21:55 ~4 min macos 📦zip
✔️ d94dea8 #15 2024-12-13 01:22:07 ~4 min ios 📦zip
✔️ d94dea8 #15 2024-12-13 01:22:25 ~4 min linux 📦zip
✔️ d94dea8 #15 2024-12-13 01:22:53 ~5 min android 📦aar
✖️ d94dea8 #15 2024-12-13 01:23:21 ~5 min tests-rpc 📄log
✔️ d94dea8 #15 2024-12-13 01:25:55 ~8 min macos 📦zip
✔️ d94dea8 #17 2024-12-13 01:46:59 ~29 min tests 📄log
✖️ d94dea8 #16 2024-12-13 03:56:13 ~4 min tests-rpc 📄log
✖️ d94dea8 #17 2024-12-13 04:05:46 ~4 min tests-rpc 📄log
✔️ d94dea8 #18 2024-12-13 06:46:37 ~6 min tests-rpc 📄log
✔️ 94a5792 #16 2024-12-13 09:13:08 ~4 min windows 📦zip
✔️ 94a5792 #16 2024-12-13 09:13:17 ~4 min macos 📦zip
✔️ 94a5792 #16 2024-12-13 09:13:23 ~4 min ios 📦zip
✔️ 94a5792 #16 2024-12-13 09:13:31 ~4 min linux 📦zip
✔️ 94a5792 #16 2024-12-13 09:14:09 ~5 min android 📦aar
✖️ 94a5792 #19 2024-12-13 09:14:45 ~5 min tests-rpc 📄log
✔️ 94a5792 #16 2024-12-13 09:19:21 ~10 min macos 📦zip
✔️ 94a5792 #18 2024-12-13 09:39:06 ~30 min tests 📄log
✔️ a5d990b #17 2024-12-13 20:59:39 ~4 min windows 📦zip
✔️ a5d990b #17 2024-12-13 21:00:24 ~5 min android 📦aar
✔️ a5d990b #17 2024-12-13 21:00:34 ~5 min linux 📦zip
✔️ a5d990b #17 2024-12-13 21:00:37 ~5 min ios 📦zip
✔️ a5d990b #17 2024-12-13 21:00:54 ~5 min macos 📦zip
✔️ a5d990b #20 2024-12-13 21:01:27 ~6 min tests-rpc 📄log
✔️ a5d990b #17 2024-12-13 21:05:33 ~10 min macos 📦zip
✔️ a5d990b #19 2024-12-13 21:25:19 ~29 min tests 📄log
✔️ ebced90 #18 2024-12-13 21:55:49 ~4 min windows 📦zip
✔️ ebced90 #18 2024-12-13 21:56:20 ~4 min linux 📦zip
✔️ ebced90 #18 2024-12-13 21:56:51 ~5 min macos 📦zip
✔️ ebced90 #18 2024-12-13 21:56:58 ~5 min android 📦aar
✔️ ebced90 #18 2024-12-13 21:56:58 ~5 min ios 📦zip
✖️ ebced90 #21 2024-12-13 21:57:36 ~6 min tests-rpc 📄log
✔️ ebced90 #18 2024-12-13 22:00:36 ~9 min macos 📦zip
✖️ ebced90 #20 2024-12-13 22:21:14 ~29 min tests 📄log
✔️ ebced90 #21 2024-12-14 00:19:46 ~30 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7a3315a #19 2024-12-14 00:31:46 ~4 min windows 📦zip
✔️ 7a3315a #19 2024-12-14 00:32:00 ~4 min macos 📦zip
✔️ 7a3315a #19 2024-12-14 00:32:10 ~4 min ios 📦zip
✔️ 7a3315a #19 2024-12-14 00:32:34 ~5 min linux 📦zip
✔️ 7a3315a #19 2024-12-14 00:32:36 ~5 min android 📦aar
✖️ 7a3315a #22 2024-12-14 00:33:47 ~6 min tests-rpc 📄log
✔️ 7a3315a #19 2024-12-14 00:37:42 ~10 min macos 📦zip
✔️ 7a3315a #22 2024-12-14 00:57:41 ~30 min tests 📄log
✔️ 7a3315a #23 2024-12-14 01:32:30 ~5 min tests-rpc 📄log
✔️ 2e23870 #20 2024-12-19 00:27:26 ~4 min windows 📦zip
✔️ 2e23870 #20 2024-12-19 00:28:29 ~5 min ios 📦zip
✔️ 2e23870 #20 2024-12-19 00:28:37 ~5 min macos 📦zip
✔️ 2e23870 #20 2024-12-19 00:28:47 ~5 min linux 📦zip
✔️ 2e23870 #20 2024-12-19 00:28:50 ~5 min android 📦aar
✔️ 2e23870 #24 2024-12-19 00:29:29 ~6 min tests-rpc 📄log
✔️ 2e23870 #20 2024-12-19 00:35:09 ~12 min macos 📦zip
✖️ 2e23870 #23 2024-12-19 00:52:27 ~29 min tests 📄log

@adklempner adklempner force-pushed the feat/telem-message-by-type branch 2 times, most recently from 76e8d11 to 9009d00 Compare December 8, 2024 03:19
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 19.30%. Comparing base (74db631) to head (2e23870).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
protocol/common/message_sender.go 0.00% 16 Missing and 2 partials ⚠️
telemetry/client.go 0.00% 12 Missing ⚠️
protocol/messenger_peersyncing.go 0.00% 7 Missing and 1 partial ⚠️
protocol/messenger.go 0.00% 1 Missing ⚠️
waku/api.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (74db631) and HEAD (2e23870). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (74db631) HEAD (2e23870)
unit 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6176       +/-   ##
============================================
- Coverage    61.27%   19.30%   -41.98%     
============================================
  Files          833      811       -22     
  Lines       109910   107929     -1981     
============================================
- Hits         67348    20832    -46516     
- Misses       34711    84266    +49555     
+ Partials      7851     2831     -5020     
Flag Coverage Δ
functional 19.30% <0.00%> (-0.04%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/messenger.go 25.12% <0.00%> (-38.86%) ⬇️
waku/api.go 0.00% <0.00%> (-36.30%) ⬇️
protocol/messenger_peersyncing.go 21.05% <0.00%> (-1.55%) ⬇️
telemetry/client.go 0.00% <0.00%> (-73.40%) ⬇️
protocol/common/message_sender.go 37.72% <0.00%> (-33.08%) ⬇️

... and 629 files with indirect coverage changes

@adklempner adklempner force-pushed the feat/telem-message-by-type branch 2 times, most recently from 055bb1d to c4644e7 Compare December 9, 2024 22:45
@adklempner adklempner changed the title Feat/telem message by type feat(telem)_: track raw message by type on dispatch Dec 9, 2024
@adklempner adklempner force-pushed the feat/telem-message-by-type branch 11 times, most recently from d94dea8 to 94a5792 Compare December 13, 2024 09:08
@adklempner adklempner changed the title feat(telem)_: track raw message by type on dispatch feat(telem)_: track raw message by type on send Dec 13, 2024
@adklempner adklempner force-pushed the feat/telem-message-by-type branch 3 times, most recently from ebced90 to 7a3315a Compare December 14, 2024 00:27
@adklempner adklempner marked this pull request as ready for review December 14, 2024 03:11
@adklempner adklempner force-pushed the feat/telem-message-by-type branch from 7a3315a to 2e23870 Compare December 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants