fix_: bad peer check logic for lightmode and some fixes #5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chaitanyaprem
commented
Oct 18, 2024
•
chaitanyaprem
commented
- Simple bad peer removal logic for lightclients based on dial failures.May help improve scenarios such as Significant delay or missing messages on 4G in community (without re-login or app closure) status-mobile#21172
- Additional fixes as per fix: use bad peer removal logic only for lightpush and filter and option to restart missing message verifier waku-org/go-waku#1244
- Increase lightpush service node rate-limit to match https://github.com/waku-org/go-waku/pull/1267/files
Jenkins BuildsClick to see older builds (175)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5964 +/- ##
===========================================
- Coverage 61.44% 61.39% -0.06%
===========================================
Files 834 834
Lines 109919 109925 +6
===========================================
- Hits 67543 67487 -56
- Misses 34490 34540 +50
- Partials 7886 7898 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
3 times, most recently
from
1ff9e98 to
9576201
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
9576201 to
eb75669
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
eb75669 to
801db12
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
3 times, most recently
from
c04fe5f to
18469e9
Compare
chaitanyaprem
requested review from
richard-ramos,
kaichaosun and
igor-sirotin
and removed request for
richard-ramos
chaitanyaprem
changed the title
richard-ramos
approved these changes
Nov 29, 2024
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
18469e9 to
a4a54ca
Compare
kaichaosun
approved these changes
Dec 4, 2024
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
2 times, most recently
from
8a65c5c to
9d4d3d2
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
9d4d3d2 to
bfc565c
Compare
plopezlpz
approved these changes
Dec 10, 2024
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
bfc565c to
584d810
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
584d810 to
c4e9180
Compare
4 tasks
igor-sirotin
approved these changes
Dec 17, 2024
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
5 times, most recently
from
78ca7d5 to
8acd482
Compare
… service rate limits
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
12fda16 to
d17dcc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.