Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: nwaku in status #5946

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

richard-ramos
Copy link
Member

A short summary which serves as a squashed-commit message.

A description to understand introduced changes without reading the code.

Important changes:

  • Something worth noting for reviewers.

Closes #

@status-im-auto
Copy link
Member

status-im-auto commented Oct 15, 2024

Jenkins Builds

Click to see older builds (148)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 62b6658 #1 2024-10-15 13:31:13 ~58 sec tests 📄log
✔️ 62b6658 #1 2024-10-15 13:32:48 ~2 min tests-rpc 📄log
✔️ 62b6658 #1 2024-10-15 13:34:06 ~3 min linux 📦zip
✔️ 62b6658 #1 2024-10-15 13:34:42 ~4 min ios 📦zip
✔️ 62b6658 #1 2024-10-15 13:35:35 ~5 min android 📦aar
cf07232 #2 2024-10-15 16:25:00 ~30 sec android 📄log
cf07232 #2 2024-10-15 16:25:01 ~29 sec ios 📄log
cf07232 #2 2024-10-15 16:25:08 ~32 sec linux 📄log
✖️ cf07232 #2 2024-10-15 16:25:26 ~51 sec tests 📄log
✖️ cf07232 #2 2024-10-15 16:25:52 ~1 min tests-rpc 📄log
ac519a1 #3 2024-10-17 14:51:31 ~30 sec android 📄log
ac519a1 #3 2024-10-17 14:51:31 ~29 sec ios 📄log
✖️ ac519a1 #3 2024-10-17 14:52:14 ~1 min tests-rpc 📄log
ac519a1 #3 2024-10-17 14:52:49 ~1 min linux 📄log
✖️ ac519a1 #3 2024-10-17 14:53:35 ~2 min tests 📄log
498dd95 #4 2024-10-17 22:06:46 ~1 min ios 📄log
✖️ 498dd95 #4 2024-10-17 22:06:50 ~1 min tests 📄log
498dd95 #4 2024-10-17 22:07:02 ~1 min android 📄log
✖️ 498dd95 #4 2024-10-17 22:07:12 ~1 min tests-rpc 📄log
498dd95 #4 2024-10-17 22:07:15 ~1 min linux 📄log
70b1011 #5 2024-10-18 15:33:09 ~47 sec android 📄log
70b1011 #5 2024-10-18 15:33:26 ~1 min ios 📄log
✖️ 70b1011 #5 2024-10-18 15:34:09 ~1 min tests 📄log
✖️ 70b1011 #5 2024-10-18 15:34:22 ~1 min tests-rpc 📄log
70b1011 #5 2024-10-18 15:34:34 ~2 min linux 📄log
8198ac1 #6 2024-10-18 15:35:13 ~41 sec ios 📄log
8198ac1 #6 2024-10-18 15:35:20 ~46 sec android 📄log
8198ac1 #6 2024-10-18 15:35:39 ~49 sec linux 📄log
✖️ 8198ac1 #6 2024-10-18 15:36:22 ~1 min tests-rpc 📄log
✖️ 8198ac1 #6 2024-10-18 15:37:41 ~3 min tests 📄log
d6079c7 #7 2024-10-23 20:24:27 ~1 min ios 📄log
d6079c7 #7 2024-10-23 20:25:05 ~1 min android 📄log
d6079c7 #7 2024-10-23 20:25:21 ~2 min linux 📄log
✖️ d6079c7 #7 2024-10-23 20:25:21 ~2 min tests-rpc 📄log
✖️ d6079c7 #7 2024-10-23 20:26:53 ~3 min tests 📄log
6dd9b20 #8 2024-10-23 20:27:39 ~1 min ios 📄log
6dd9b20 #8 2024-10-23 20:27:54 ~2 min android 📄log
6dd9b20 #8 2024-10-23 20:28:04 ~2 min linux 📄log
✖️ 6dd9b20 #8 2024-10-23 20:28:15 ~2 min tests-rpc 📄log
✖️ 6dd9b20 #8 2024-10-23 20:30:14 ~3 min tests 📄log
ed5a9aa #9 2024-10-24 14:35:32 ~11 sec linux 📄log
✔️ ed5a9aa #9 2024-10-24 14:39:08 ~3 min ios 📦zip
✔️ ed5a9aa #9 2024-10-24 14:39:37 ~4 min android 📦aar
✖️ ed5a9aa #9 2024-10-24 14:41:43 ~6 min tests-rpc 📄log
✖️ ed5a9aa #9 2024-10-24 15:04:35 ~29 min tests 📄log
✖️ 8c4c876 #10 2024-10-25 08:05:17 ~1 min tests 📄log
✔️ 8c4c876 #10 2024-10-25 08:06:15 ~2 min ios 📦zip
✔️ 8c4c876 #10 2024-10-25 08:08:08 ~4 min linux 📦zip
✖️ 8c4c876 #10 2024-10-25 08:08:52 ~5 min tests-rpc 📄log
✔️ 8c4c876 #10 2024-10-25 08:09:05 ~5 min android 📦aar
✖️ 8661a71 #11 2024-10-28 20:21:14 ~1 min tests 📄log
✔️ 8661a71 #11 2024-10-28 20:22:20 ~3 min android 📦aar
✔️ 8661a71 #11 2024-10-28 20:22:45 ~3 min ios 📦zip
✔️ 8661a71 #11 2024-10-28 20:23:40 ~4 min linux 📦zip
✖️ 8661a71 #11 2024-10-28 20:25:05 ~5 min tests-rpc 📄log
✖️ 38353ca #12 2024-10-29 13:35:42 ~1 min tests 📄log
✔️ 38353ca #12 2024-10-29 13:36:52 ~2 min android 📦aar
✔️ 38353ca #12 2024-10-29 13:37:26 ~3 min linux 📦zip
✔️ 38353ca #12 2024-10-29 13:37:32 ~3 min ios 📦zip
✖️ 38353ca #12 2024-10-29 13:39:43 ~5 min tests-rpc 📄log
e829dea #13 2024-10-29 16:23:19 ~12 sec linux 📄log
✔️ e829dea #13 2024-10-29 16:25:53 ~2 min android 📦aar
✖️ e829dea #13 2024-10-29 16:26:31 ~3 min tests 📄log
✖️ e829dea #13 2024-10-29 16:27:09 ~3 min tests-rpc 📄log
✔️ e829dea #1 2024-10-29 16:27:39 ~4 min macos 📦zip
✔️ e829dea #13 2024-10-29 16:28:15 ~5 min ios 📦zip
✔️ e829dea #1 2024-10-29 16:31:28 ~8 min macos 📦zip
✖️ e829dea #1 2024-10-29 16:34:12 ~11 min windows 📦zip
fd9d9f3 #14 2024-10-29 16:32:02 ~25 sec linux 📄log
✔️ fd9d9f3 #2 2024-10-29 16:35:21 ~3 min macos 📦zip
✔️ fd9d9f3 #14 2024-10-29 16:35:24 ~3 min ios 📦zip
✖️ fd9d9f3 #14 2024-10-29 16:35:48 ~4 min tests-rpc 📄log
✔️ fd9d9f3 #14 2024-10-29 16:36:57 ~5 min android 📦aar
✔️ fd9d9f3 #2 2024-10-29 16:40:17 ~8 min macos 📦zip
✖️ fd9d9f3 #14 2024-10-29 16:44:43 ~13 min tests 📄log
✖️ fd9d9f3 #2 2024-10-29 16:45:22 ~11 min windows 📦zip
✔️ 6ac236d #15 2024-10-30 16:27:47 ~3 min android 📦aar
✔️ 6ac236d #3 2024-10-30 16:28:05 ~3 min macos 📦zip
✖️ 6ac236d #15 2024-10-30 16:28:31 ~4 min tests-rpc 📄log
✔️ 6ac236d #15 2024-10-30 16:29:12 ~4 min ios 📦zip
✔️ 6ac236d #15 2024-10-30 16:29:40 ~5 min linux 📦zip
✖️ 6ac236d #3 2024-10-30 16:35:34 ~11 min windows 📦zip
✖️ 6ac236d #15 2024-10-30 16:37:52 ~13 min tests 📄log
✔️ 6ac236d #3 2024-10-30 16:39:32 ~15 min macos 📦zip
✖️ d17610d #16 2024-10-31 14:43:43 ~3 min tests-rpc 📄log
✔️ d17610d #16 2024-10-31 14:46:32 ~6 min linux 📦zip
✔️ d17610d #4 2024-10-31 14:46:33 ~5 min macos 📦zip
✔️ d17610d #16 2024-10-31 14:46:51 ~6 min android 📦aar
✔️ d17610d #16 2024-10-31 14:48:18 ~7 min ios 📦zip
✔️ d17610d #4 2024-10-31 14:48:54 ~8 min macos 📦zip
✖️ d17610d #4 2024-10-31 14:51:53 ~11 min windows 📦zip
✖️ d17610d #16 2024-10-31 14:56:17 ~15 min tests 📄log
✖️ 28ee341 #17 2024-11-11 02:21:37 ~1 min tests 📄log
28ee341 #17 2024-11-11 02:21:49 ~1 min ios 📄log
28ee341 #17 2024-11-11 02:22:17 ~2 min android 📄log
28ee341 #17 2024-11-11 02:22:23 ~2 min linux 📄log
28ee341 #5 2024-11-11 02:22:28 ~2 min macos 📄log
✖️ 28ee341 #17 2024-11-11 02:22:30 ~2 min tests-rpc 📄log
28ee341 #5 2024-11-11 02:24:25 ~4 min windows 📄log
28ee341 #5 2024-11-11 02:25:54 ~5 min macos 📄log
✖️ cc2022b #18 2024-12-03 13:08:39 ~1 min tests 📄log
cc2022b #18 2024-12-03 13:08:42 ~1 min linux 📄log
cc2022b #18 2024-12-03 13:08:51 ~2 min android 📄log
✖️ cc2022b #18 2024-12-03 13:09:18 ~2 min tests-rpc 📄log
cc2022b #18 2024-12-03 13:09:42 ~2 min ios 📄log
cc2022b #6 2024-12-03 13:09:46 ~2 min macos 📄log
cc2022b #6 2024-12-03 13:10:44 ~3 min windows 📄log
cc2022b #6 2024-12-03 13:11:55 ~5 min macos 📄log
387d45d #19 2024-12-10 19:45:49 ~1 min ios 📄log
✖️ 387d45d #19 2024-12-10 19:45:58 ~1 min tests 📄log
387d45d #19 2024-12-10 19:46:04 ~2 min linux 📄log
387d45d #19 2024-12-10 19:46:23 ~2 min android 📄log
✖️ 387d45d #19 2024-12-10 19:46:28 ~2 min tests-rpc 📄log
387d45d #7 2024-12-10 19:47:53 ~3 min windows 📄log
387d45d #7 2024-12-10 19:48:05 ~4 min macos 📄log
387d45d #7 2024-12-10 19:48:21 ~4 min macos 📄log
a87bed5 #20 2024-12-12 12:31:38 ~1 min linux 📄log
a87bed5 #8 2024-12-12 12:31:46 ~1 min macos 📄log
✖️ a87bed5 #20 2024-12-12 12:32:12 ~1 min tests 📄log
a87bed5 #20 2024-12-12 12:32:17 ~1 min ios 📄log
a87bed5 #20 2024-12-12 12:32:22 ~1 min android 📄log
✖️ a87bed5 #20 2024-12-12 12:32:45 ~2 min tests-rpc 📄log
a87bed5 #8 2024-12-12 12:32:54 ~2 min windows 📄log
a87bed5 #8 2024-12-12 12:33:19 ~2 min macos 📄log
d97f1ed #21 2024-12-17 18:38:35 ~1 min ios 📄log
✖️ d97f1ed #21 2024-12-17 18:38:39 ~1 min tests 📄log
d97f1ed #9 2024-12-17 18:38:47 ~1 min macos 📄log
d97f1ed #21 2024-12-17 18:38:48 ~1 min linux 📄log
d97f1ed #21 2024-12-17 18:39:10 ~2 min android 📄log
✖️ d97f1ed #21 2024-12-17 18:39:26 ~2 min tests-rpc 📄log
d97f1ed #9 2024-12-17 18:40:51 ~3 min windows 📄log
d97f1ed #9 2024-12-17 18:42:36 ~5 min macos 📄log
415b569 #22 2024-12-18 17:55:15 ~1 min linux 📄log
415b569 #10 2024-12-18 17:55:18 ~1 min macos 📄log
415b569 #22 2024-12-18 17:55:43 ~1 min ios 📄log
✖️ 415b569 #22 2024-12-18 17:55:43 ~1 min tests 📄log
415b569 #22 2024-12-18 17:56:19 ~2 min android 📄log
415b569 #10 2024-12-18 17:56:27 ~2 min windows 📄log
✖️ 415b569 #22 2024-12-18 17:56:41 ~2 min tests-rpc 📄log
415b569 #10 2024-12-18 17:57:37 ~3 min macos 📄log
✖️ 77ba191 #23 2024-12-18 18:11:50 ~41 sec tests-rpc 📄log
77ba191 #23 2024-12-18 18:12:07 ~1 min linux 📄log
77ba191 #11 2024-12-18 18:12:16 ~1 min macos 📄log
77ba191 #23 2024-12-18 18:12:39 ~1 min ios 📄log
✖️ 77ba191 #23 2024-12-18 18:12:44 ~1 min tests 📄log
77ba191 #23 2024-12-18 18:12:54 ~1 min android 📄log
77ba191 #11 2024-12-18 18:13:22 ~2 min windows 📄log
77ba191 #11 2024-12-18 18:15:25 ~4 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
4e87232 #24 2024-12-18 19:25:49 ~1 min linux 📄log
4e87232 #12 2024-12-18 19:25:57 ~1 min macos 📄log
4e87232 #24 2024-12-18 19:26:16 ~1 min ios 📄log
✖️ 4e87232 #24 2024-12-18 19:26:26 ~1 min tests 📄log
4e87232 #24 2024-12-18 19:26:27 ~1 min android 📄log
4e87232 #12 2024-12-18 19:27:07 ~2 min windows 📄log
✖️ 4e87232 #24 2024-12-18 19:27:29 ~2 min tests-rpc 📄log
4e87232 #12 2024-12-18 19:28:07 ~3 min macos 📄log
a3bff47 #25 2024-12-18 19:27:54 ~1 min ios 📄log
a3bff47 #13 2024-12-18 19:28:03 ~1 min macos 📄log
✖️ a3bff47 #25 2024-12-18 19:28:14 ~1 min tests 📄log
a3bff47 #25 2024-12-18 19:28:17 ~2 min linux 📄log
a3bff47 #25 2024-12-18 19:28:22 ~1 min android 📄log
a3bff47 #13 2024-12-18 19:29:21 ~2 min windows 📄log
✖️ a3bff47 #25 2024-12-18 19:30:13 ~2 min tests-rpc 📄log
a3bff47 #13 2024-12-18 19:34:56 ~6 min macos 📄log

@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from ac519a1 to 498dd95 Compare October 17, 2024 22:05
@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from 70b1011 to 8198ac1 Compare October 18, 2024 15:34
@richard-ramos richard-ramos changed the title feat: nwaku in status feat_: nwaku in status Oct 23, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 395 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (eea527a) to head (fd9d9f3).

Files with missing lines Patch % Lines
protocol/messenger_mailserver.go 0.00% 75 Missing ⚠️
protocol/messenger_mailserver_cycle.go 0.00% 71 Missing ⚠️
eth-node/bridge/geth/wakuv2.go 0.00% 38 Missing ⚠️
wakuv2/nwaku_test_utils.go 0.00% 28 Missing ⚠️
protocol/messenger_communities.go 0.00% 25 Missing ⚠️
eth-node/bridge/geth/waku.go 0.00% 24 Missing ⚠️
protocol/transport/transport.go 0.00% 23 Missing ⚠️
timesource/timesource.go 0.00% 18 Missing ⚠️
protocol/messenger.go 0.00% 14 Missing ⚠️
wakuv2/gowaku.go 0.00% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5946       +/-   ##
============================================
- Coverage    13.07%    0.00%   -13.08%     
============================================
  Files          797      797               
  Lines       107755   107347      -408     
============================================
- Hits         14087        0    -14087     
- Misses       91867   107347    +15480     
+ Partials      1801        0     -1801     
Flag Coverage Δ
functional 0.00% <0.00%> (-13.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/messenger_peers.go 0.00% <ø> (-9.10%) ⬇️
wakuv2/message_publishing.go 0.00% <ø> (-49.24%) ⬇️
wakuv2/shard.go 0.00% <ø> (ø)
node/status_node_services.go 0.00% <0.00%> (-57.48%) ⬇️
protocol/requests/set_community_shard.go 0.00% <0.00%> (ø)
protocol/transport/filters_manager.go 0.00% <0.00%> (-35.16%) ⬇️
services/status/service.go 0.00% <0.00%> (-63.64%) ⬇️
eth-node/types/topic.go 0.00% <0.00%> (-15.91%) ⬇️
protocol/communities/persistence_mapping.go 0.00% <0.00%> (ø)
protocol/linkpreview_unfurler_status.go 0.00% <0.00%> (ø)
... and 24 more

... and 347 files with indirect coverage changes

@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from e829dea to fd9d9f3 Compare October 29, 2024 16:31
@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from 77ba191 to 4e87232 Compare December 18, 2024 19:24
- some minor progress to add nwaku in status-go
- nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty
- waku_test.go: adapt TestWakuV2Store
- add missing shard.go
- feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896)
- chore_: update nwaku
- nwaku bump (#5911)
- bump: nwaku
- chore: add USE_NWAKU env flag
- fix: build libwaku only if needed
- feat: testing discovery and dialing with nwaku integration (#5940)
- message publisher and sent verifier (#5966)
- storenode requestor for missing message retrieval and result iterator impl (#5971)
- uncomment code that would allow status-go/go-waku to compile and libwaku test to run (#5986)
- supporting peer exchange with nwaku (#5983)
- store queries
- ping
- ping storenodes using AddrInfo (#6004)
- dial, drop and retrieve connected peers  (#6013)
- integrate on-demand DNS discovery and implement discoverAndConnectPeers (#6017)
- extract libwaku calls into WakuNode struct (#6027)
- async nwaku
- remove nwaku process loop
- receive messages via relay (#6185)
- extract timeout from context
- use correct port field, get free ports and uncomment some functions (#6200)
- enable filter/lightpush/px and setup rate limits
- add protected topics
@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch from 4e87232 to a3bff47 Compare December 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants