parent 3179532

author shashankshampi <[email protected]> 1729780155 +0530 committer shashankshampi <[email protected]> 1730274350 +0530 test: Code Migration from status-cli-tests fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <[email protected]> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue status-im/status-mobile#21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR status-im/status-mobile#21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <[email protected]> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments fix(ci)_: remove workspace and tmp dir This ensures we do not encounter weird errors like: ``` + ln -s /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907 /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go ln: failed to create symbolic link '/home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go': File exists script returned exit code 1 ``` Signed-off-by: Jakub Sokołowski <[email protected]> chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes status-im/status-desktop#16392 cleanup added logger and cleanup review comments changes fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <[email protected]> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue status-im/status-mobile#21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR status-im/status-mobile#21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <[email protected]> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes status-im/status-desktop#16392 test_: remove port bind chore(wallet)_: move route execution code to separate module chore_: replace geth logger with zap logger (#5962) closes: #6002 feat(telemetry)_: add metrics for message reliability (#5899) * feat(telemetry)_: track message reliability Add metrics for dial errors, missed messages, missed relevant messages, and confirmed delivery. * fix_: handle error from json marshal chore_: use zap logger as request logger iterates: status-im/status-desktop#16536 test_: unique project per run test_: use docker compose v2, more concrete project name fix(codecov)_: ignore folders without tests Otherwise Codecov reports incorrect numbers when making changes. https://docs.codecov.com/docs/ignoring-paths Signed-off-by: Jakub Sokołowski <[email protected]> test_: verify schema of signals during init; fix schema verification warnings (#5947) fix_: update defaultGorushURL (#6011) fix(tests)_: use non-standard port to avoid conflicts We have observed `nimbus-eth2` build failures reporting this port: ```json { "lvl": "NTC", "ts": "2024-10-28 13:51:32.308+00:00", "msg": "REST HTTP server could not be started", "topics": "beacnde", "address": "127.0.0.1:5432", "reason": "(98) Address already in use" } ``` https://ci.status.im/job/nimbus-eth2/job/platforms/job/linux/job/x86_64/job/main/job/PR-6683/3/ Signed-off-by: Jakub Sokołowski <[email protected]> fix_: create request logger ad-hoc in tests Fixes `TestCall` failing when run concurrently. chore_: configure codecov (#6005) * chore_: configure codecov * fix_: after_n_builds
status-im · Oct 30, 2024 · c67d403 · c67d403
1 parent 3179532
commit c67d403
Show file tree

Hide file tree

Showing 403 changed files with 33,056 additions and 2,252 deletions.
diff --git a/.codecov.yml b/.codecov.yml
@@ -4,30 +4,38 @@
 codecov:
   require_ci_to_pass: false
   notify:
-    wait_for_ci: true
+    wait_for_ci: false
+    after_n_builds: 2
+
+ignore:
+  - "_.*"
+  - "vendor"
+  - "scripts"
+  - "contracts"
+  - "Makefile"
 
 coverage:
   status:
     project:
-      default:
-        informational: true
       unit-tests:
         target: auto
+        threshold: 1
         flags:
           - unit
       functional-tests:
+        threshold: 0.1
         target: auto
         flags:
           - functional
     patch:
       default:
-        informational: true
+        target: 50
       unit-tests:
-        target: auto
+        informational: true
         flags:
           - unit
       functional-tests:
-        target: auto
+        informational: true
         flags:
           - functional
 
@@ -39,7 +47,7 @@ flags:
   functional-tests:
     paths:
       - ".*"
-    carryforward: true
+    carryforward: false
 
 comment:
   behavior: default

diff --git a/Makefile b/Makefile
@@ -193,6 +193,11 @@ statusgo-cross: statusgo-android statusgo-ios
 	@echo "Full cross compilation done."
 	@ls -ld build/bin/statusgo-*
 
+status-go-deps:
+	go install go.uber.org/mock/[email protected]
+	go install github.com/kevinburke/go-bindata/v4/[email protected]
+	go install google.golang.org/protobuf/cmd/[email protected]
+
 statusgo-android: generate
 statusgo-android: ##@cross-compile Build status-go for Android
 	@echo "Building status-go for Android..."
@@ -398,6 +403,7 @@ test-e2e: ##@tests Run e2e tests
 test-e2e-race: export GOTEST_EXTRAFLAGS=-race
 test-e2e-race: test-e2e ##@tests Run e2e tests with -race flag
 
+test-functional: generate
 test-functional: export FUNCTIONAL_TESTS_DOCKER_UID ?= $(call sh, id -u)
 test-functional: export FUNCTIONAL_TESTS_REPORT_CODECOV ?= false
 test-functional:
@@ -407,7 +413,10 @@ canary-test: node-canary
 	# TODO: uncomment that!
 	#_assets/scripts/canary_test_mailservers.sh ./config/cli/fleet-eth.prod.json
 
-lint: generate
+lint-panics: generate
+	go run ./cmd/lint-panics -root="$(call sh, pwd)" -skip=./cmd -test=false ./...
+
+lint: generate lint-panics
 	golangci-lint run ./...
 
 ci: generate lint canary-test test-unit test-e2e ##@tests Run all linters and tests at once

diff --git a/_assets/ci/Jenkinsfile b/_assets/ci/Jenkinsfile
@@ -1,5 +1,5 @@
 #!/usr/bin/env groovy
-library '[email protected].6'
+library '[email protected].12'
 
 pipeline {
   agent { label 'linux' }
@@ -52,6 +52,12 @@ pipeline {
         stage('Linux') { steps { script {
           linux = jenkins.Build('status-go/platforms/linux')
         } } }
+        stage('MacOS') { steps { script {
+          linux = jenkins.Build('status-go/platforms/macos')
+        } } }
+        stage('Windows') { steps { script {
+          linux = jenkins.Build('status-go/platforms/windows')
+        } } }
         stage('Docker') { steps { script {
           dock = jenkins.Build('status-go/platforms/docker')
         } } }

diff --git a/_assets/ci/Jenkinsfile.android b/_assets/ci/Jenkinsfile.android
@@ -85,6 +85,9 @@ pipeline {
   post {
     success { script { github.notifyPR(true) } }
     failure { script { github.notifyPR(false) } }
-    cleanup { sh 'make deep-clean' }
+    cleanup {
+      cleanWs()
+      dir("${env.WORKSPACE}@tmp") { deleteDir() }
+    }
   } // post
 } // pipeline
diff --git a/_assets/ci/Jenkinsfile.desktop b/_assets/ci/Jenkinsfile.desktop
@@ -0,0 +1,166 @@
+#!/usr/bin/env groovy
+library '[email protected]'
+
+pipeline {
+  /* This way we run the same Jenkinsfile on different platforms. */
+  agent { label "${params.AGENT_LABEL}" }
+
+  parameters {
+    string(
+      name: 'BRANCH',
+      defaultValue: 'develop',
+      description: 'Name of branch to build.'
+    )
+    string(
+      name: 'AGENT_LABEL',
+      description: 'Label for targetted CI slave host.',
+      defaultValue: params.AGENT_LABEL ?: getAgentLabel(),
+    )
+    booleanParam(
+      name: 'RELEASE',
+      defaultValue: false,
+      description: 'Enable to create build for release.',
+    )
+  }
+
+  options {
+    timestamps()
+    ansiColor('xterm')
+    /* Prevent Jenkins jobs from running forever */
+    timeout(time: 15, unit: 'MINUTES')
+    disableConcurrentBuilds()
+    /* manage how many builds we keep */
+    buildDiscarder(logRotator(
+      numToKeepStr: '5',
+      daysToKeepStr: '30',
+      artifactNumToKeepStr: '1',
+    ))
+  }
+
+  environment {
+    PLATFORM = getPlatformFromLabel(params.AGENT_LABEL)
+    TMPDIR   = "${WORKSPACE_TMP}"
+    GOPATH   = "${WORKSPACE_TMP}/go"
+    GOCACHE  = "${WORKSPACE_TMP}/gocache"
+    PATH     = "${PATH}:${GOPATH}/bin:/c/Users/jenkins/go/bin"
+    REPO_SRC = "${GOPATH}/src/github.com/status-im/status-go"
+    VERSION  = sh(script: "./_assets/scripts/version.sh", returnStdout: true)
+    ARTIFACT = utils.pkgFilename(
+      name:    'status-go',
+      type:    env.PLATFORM,
+      version: env.VERSION,
+      ext:     'zip',
+    )
+    /* prevent sharing cache dir across different jobs */
+    GO_GENERATE_FAST_DIR = "${env.WORKSPACE_TMP}/go-generate-fast"
+  }
+
+  stages {
+    stage('Setup') {
+        steps {
+          script {
+            if (env.PLATFORM != 'windows') {
+                sh "mkdir -p \$(dirname ${REPO_SRC})"
+                sh "ln -s ${WORKSPACE} ${REPO_SRC}"
+              }
+          }
+      }
+  }
+
+    stage('Deps') {
+      steps { script {
+        shell('make status-go-deps')
+      }
+    }
+  }
+
+    stage('Generate') {
+      steps { script {
+        shell('make generate')
+      }
+    }
+  }
+
+    stage('Build Static Lib') {
+        steps {
+            script {
+                shell('make statusgo-library')
+                }
+            }
+        }
+
+    stage('Build Shared Lib') {
+        steps {
+            script {
+                shell('make statusgo-shared-library')
+                }
+            }
+        }
+
+    stage('Archive') {
+        steps {
+          zip zipFile: "${ARTIFACT}", archive: true, dir: 'build/bin'
+            }
+        }
+
+    stage('Upload') {
+        steps {
+            script {
+                env.PKG_URL = s5cmd.upload(ARTIFACT)
+            }
+        }
+    }
+    stage('Cleanup') {
+        steps {
+            script {
+                cleanTmp()
+                }
+            }
+        }
+} // stages
+  post {
+     success { script { github.notifyPR(true) } }
+     failure { script { github.notifyPR(false) } }
+     cleanup { cleanWs() }
+  } // post
+} // pipeline
+
+/* This allows us to use one Jenkinsfile and run
+ * jobs on different platforms based on job name. */
+def getAgentLabel() {
+    if (params.AGENT_LABEL) { return params.AGENT_LABEL }
+    /* We extract the name of the job from currentThread because
+     * before an agent is picket env is not available. */
+    def tokens = Thread.currentThread().getName().split('/')
+    def labels = []
+    /* Check if the job path contains any of the valid labels. */
+    ['linux', 'macos', 'windows', 'x86_64', 'aarch64', 'arm64'].each {
+        if (tokens.contains(it)) { labels.add(it) }
+    }
+    return labels.join(' && ')
+}
+
+/* This function extracts the platform from the AGENT_LABEL */
+def getPlatformFromLabel(label) {
+    for (platform in ['linux', 'macos', 'windows']) {
+        if (label.contains(platform)) {
+            return platform
+        }
+    }
+}
+
+def shell(cmd) {
+    if (env.PLATFORM == 'windows') {
+        sh "${cmd} SHELL=/bin/sh"
+    } else {
+        nix.shell(cmd, pure: false) // Use nix.shell for Linux/macOS
+    }
+}
+
+def cleanTmp() {
+    if (env.PLATFORM == 'windows') {
+        sh "rm -rf ${env.WORKSPACE}@tmp"
+    } else {
+        dir("${env.WORKSPACE}@tmp") { deleteDir() }
+    }
+}
diff --git a/_assets/ci/Jenkinsfile.ios b/_assets/ci/Jenkinsfile.ios
@@ -89,6 +89,9 @@ pipeline {
   post {
     success { script { github.notifyPR(true) } }
     failure { script { github.notifyPR(false) } }
-    cleanup { sh 'make deep-clean' }
+    cleanup {
+      cleanWs()
+      dir("${env.WORKSPACE}@tmp") { deleteDir() }
+    }
   } // post
 } // pipeline
diff --git a/_assets/ci/Jenkinsfile.linux b/_assets/ci/Jenkinsfile.linux
diff --git a/_assets/ci/Jenkinsfile.linux b/_assets/ci/Jenkinsfile.linux
@@ -0,0 +1 @@
+Jenkinsfile.desktop
diff --git a/_assets/ci/Jenkinsfile.macos b/_assets/ci/Jenkinsfile.macos
@@ -0,0 +1 @@
+Jenkinsfile.desktop