-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate previews from forked repos #1097
Conversation
020ccd4
to
7cb733b
Compare
@stoobie I have finished, please help me to review. |
The workflow triggered from |
@xiaolou86 Wonderful! Thank you for your hard work on this! I need to have another set of eyes review the code before I can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @xiaolou86)
@guyvelleman gave an LGTM offline. |
Description of the Changes
fix: Generate previews from forked repos
Closes #1043
Description of the Solution
Change the event from
pull_request
topull_request_target
. permissions-for-the-github_tokenChange the branch ref when checkout. Because its event (pull_request_target) runs in the context of the base of the pull request, rather than in the context of the merge commit as the pull_request event does. base branch
Since of the above 2, the workflow triggered from
pull_request_target
event will run only after the .yml config has been merged into repo.PR Preview URL
After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.
Paste here the specific URL(s) of the content that this PR addresses.
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is