-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for other distros with release files and added Alpine Linux #48
Merged
stanislav-tkach
merged 20 commits into
stanislav-tkach:master
from
mattmccarty:feature/alpine-support
Dec 15, 2017
Merged
Support for other distros with release files and added Alpine Linux #48
stanislav-tkach
merged 20 commits into
stanislav-tkach:master
from
mattmccarty:feature/alpine-support
Dec 15, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty/os_info into feature/alpine-support
Thank you for the pull request. I'm going to review it as soon as possible. 😅 |
stanislav-tkach
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intention was not to rework the code, however, when adding support for Alpine Linux, I came to the conclusion that there may be other distributions that need to get version info from a file.
These changes add support for Alpine while making it easier to add support for other distros in the future.