Fix: Add Types for Ultramarine Linux #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
suggested changes
Feb 26, 2024
Yup, I have a few changes on my end addressing these, and I'm stuck on one snag currently. Hoping to have it fixed before the day is over. |
|
@ydirson, almost everything seems to be passing sans a Windows issue which is being addressed in another PR via Dependabot... Are you able to test/build now? |
ydirson
reviewed
Feb 28, 2024
os_info/src/linux/lsb_release.rs
Outdated
Comment on lines
317
to
320
| assert_eq!(parse_results.distribution, Some("UltramarineLinux".to_string())); | ||
| assert_eq!( | ||
| parse_results.distribution, | ||
| Some("UltramarineLinux".to_string()) | ||
| ); |
There was a problem hiding this comment.
this would be better folded into the commit that adds the line
os_info/src/linux/lsb_release.rs
Outdated
| parse_results.distribution, | ||
| parse_results.distribution, |
There was a problem hiding this comment.
this would be better folded into the commit that adds the line
stanislav-tkach
approved these changes
Mar 3, 2024
stanislav-tkach
merged commit 5b5e49b
into
stanislav-tkach:master
17 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely forgot to add the Types for Ultramarine on my previous PR. This should rectify that.