Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pragma deletion logic: Issue #577 #578

Merged
merged 1 commit into from
Sep 28, 2020
Merged

fix pragma deletion logic: Issue #577 #578

merged 1 commit into from
Sep 28, 2020

Conversation

jjwilke
Copy link
Contributor

@jjwilke jjwilke commented Sep 25, 2020

Not sure why the original logic was there. There's no reason to track pragma depth anymore.

@jjwilke jjwilke requested a review from calewis September 25, 2020 05:52
@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 553
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 837
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore_PY3.8

  • Build Num: 12
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore_PY3.8

  • Build Num: 11
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 400
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 654
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 383
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 642
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 125
  • Status: STARTED

Using Repos:

Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: b484bdb7f999eb15235c89851f2f05426866e146
  • Mode: SUPPORT_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 6acbd6dff75843e34dbb88912267378bc9fdc220
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 7d51c969748e1ee5b6b6aeb0cda1dde1600e12c8
  • Mode: SUPPORT_REPO
Repo: MACRO (jjwilke/sst-macro)
  • Branch: delete-pragma-577
  • SHA: fa3fc14
  • Mode: TEST_REPO

Pull Request Author: jjwilke

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 553
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 837
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore_PY3.8

  • Build Num: 12
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore_PY3.8

  • Build Num: 11
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 400
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 654
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 383
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 642
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 125
  • Status: PASSED

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

19 similar comments
@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

calewis
calewis approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@calewis calewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, generated a lot of emails. LGTM

@jjwilke jjwilke merged commit 0a5c150 into sstsimulator:devel Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calewis calewis calewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjwilke @sst-autotester @calewis