Skip to content
forked from commaai/openpilot

DOES NOT SUPPORT COMMA 3X - Stock Additions (0.8.14): 3/automatic following distance profiles, customizable fork params with opEdit, and a smoother longitudinal experience for TSS2 Toyotas

License

Notifications You must be signed in to change notification settings

sshane/openpilot

 
 

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Stock Additions - 2022-01-01 (0.8.13)

Stock Additions is a fork of openpilot designed to be minimal in design while boasting various feature additions and behavior improvements over stock. I have a 2017 Toyota Corolla with comma pedal, so most of my changes are designed to improve the longitudinal performance.

Want to request a feature or create a bug report? Open an issue here! Want to reach me to debug an issue or have a question? Shane#6175 on Discord!

View Stock Additions Changelog


Highlight Features

Behavior Changes

General Features

Visual Changes (LINKS WIP)

Documentation


Behavior changes

Dynamic follow (3 profiles)

Dynamic follow aims to provide the stock (Toyota) experience of having three different distance settings. Dynamic follow works by dynamically changing the distance in seconds which is sent to the long MPC to predict a speed to travel at. Basically, if the lead is decelerating or might soon, increase distance to prepare. And if the lead is accelerating, reduce distance to get up to speed quicker.

Dynamic follow works if openpilot can control your vehicle's gas and brakes (longitudinal). Check if openpilot can control your vehicle's longitudinal from this list.

Just use the button on the button right of the screen while driving to change between these profiles:

  • traffic - Meant to keep you a bit closer in traffic, hopefully reducing cut-ins. Always be alert, as you are with any driving assistance software.
  • relaxed - This is the default dynamic follow profile for casual driving.
  • stock - This is the stock 1.8 second profile default in stock openpilot, with no dynamic follow mods. The previous roadtrip profile was closer than a true road trip profile, this is more in line with that intention.
  • auto - The auto dynamic follow model was trained on about an hour of me manually cycling through the different profiles based on driving conditions, this profile tries to replicate those decisions entirely on its own.


Automatic DF profile switching

I've trained a custom model with Keras that takes in the past 35 seconds of your speed, the lead's speed and the lead's distance. With these inputs, it tries to correctly predict which profile is the best for your current situation.

It's only been trained on about an hour of data, so it's not perfect yet, but it's great for users who just want to set it and forget it. To enable the auto profile, simply tap the profile changing button for dynamic follow until it reaches the auto profile!

If you're annoyed by the silent alerts that show when the model has changed the profile automatically, just use opEdit and set hide_auto_df_alerts to True. Auto profile and model will remain functional but will not show alerts.

Resources:


Lane Speed alerts

This feature alerts you of faster-travelling adjacent lanes and can be configured using the on-screen LS button on the bottom right to either be disabled, audible, or silent.

The idea behind this feature is since we often become very relaxed behind the wheel when being driven by openpilot, we don't always notice when we've become stuck behind a slower-moving vehicle. When either the left or right adjacent lane is moving faster than your current lane, LaneSpeed alerts the user that a faster lane is available so that they can make a lane change, overtaking the slower current lane. Thus saving time in the long run on long road trips or in general highway driving!

The original idea is thanks to Greengree#5537 on Discord. This feature is available at 35 mph and up.


Dynamic camera offset (based on oncoming traffic)

This feature automatically adjusts your position in the lane if an adjacent lane has oncoming traffic. For example, if you're on a two-lane highway and the left adjacent lane has oncoming cars, LaneSpeed recognizes those cars and applies an offset to your CAMERA_OFFSET to move you over in the lane, keeping you farther from oncoming cars.

This feature is available from 35 to ~60 mph due to a limitation with the Toyota radar. It may not recognize oncoming traffic above 60 mph or so. To enable or disable this feature, use opEdit and change this parameter: dynamic_camera_offset.


PI -> PID Controller for Long and Lat

(long: longitudinal, speed control. lat: latitudinal, steering control)

Changes for lat control: (NEW❗)

  • Adding the derivative component to lat control greatly improves the turning performance of openpilot, I've found it loses control much less frequently in both slight and sharp curves and smooths out steering in all situations. Basically it ramps down torque as your wheel approaches the desired angle, and ramps up torque quicky when your wheel is moving away from desired.

    Currently Supported Cars: (when param use_lqr is False)

    • 2017 Toyota Corolla
    • TSS2 Toyota Corolla (when param corollaTSS2_use_indi is False) - tune from birdman!
    • All Prius years (when param prius_use_pid is True) - tune from Trae!

Changes for long control:

  • I've added a custom implementation of derivative to the PI loop controlling the gas and brake output sent to your car. Derivative (change in error) is calculated based on the current and last error and added to the class's integral variable. It's essentially winding down integral according to derivative. It helps fix overshoot on some cars with the comma pedal and increases responsiveness (like when going up and down hills) on all other cars! Still need to figure out the tuning, right now it's using the same derivative gain for all cars. Test it out and let me know what you think!

    Long derivative is disabled by default due to only one tune for all cars, but can be enabled by using opEdit and setting the enable_long_derivative parameter to True. It works well on my '17 Corolla with pedal.


General Features

Customize this fork (opEdit)

This is a handy tool to change your opParams parameters without diving into any json files or code. You can specify parameters to be used in any fork's operation that supports opParams. First, ssh in to your comma device and make sure you're in /data/openpilot, then start opEdit:

cd /data/openpilot
python op_edit.py  # or ./op_edit.py

To see what features opEdit has, click me!

🆕 All params now update live while driving, and params that are marked with static need a reboot of the device, or ignition.

Here are the main parameters you can change with this fork:

  • Tuning params:
    • camera_offset (live!): Your camera offset to use in lane_planner.py. Helps fix lane hugging
    • steer_ratio (live!): The steering ratio you want to use with openpilot. If you enter None, it will use the learned steer ratio from openpilot instead
    • use_lqr: Enable this to use LQR for lateral control with any car. It uses the RAV4 tuning, but has proven to work well for many cars
  • General fork params:
    • alca_no_nudge_speed: Above this speed (mph), lane changes initiate IMMEDIATELY after turning on the blinker. Behavior is stock under this speed (waits for torque)
    • upload_onroad: By default, openpilot uploads small qlogs while driving. Set to False to wait until we go offroad
    • update_behavior: off will never update, alert shows an alert on-screen. auto will reboot the device when an update is seen
    • disengage_on_gas: Whether you want openpilot to disengage on gas input or not
    • hide_model_long: Enable this to hide the Model Long button on the screen
  • Dynamic params:
    • dynamic_gas: Whether to use dynamic gas if your car is supported
    • global_df_mod (live!): The multiplier for the current distance used by dynamic follow. The range is limited from 0.85 to 2.5. Smaller values will get you closer, larger will get you farther. This is applied to ALL profiles!
    • min_TR (live!): The minimum allowed following distance in seconds. Default is 0.9 seconds, the range of this mod is limited from 0.85 to 1.3 seconds. This is applied to ALL profiles!
    • hide_auto_df_alerts: Hides the alert that shows what profile the model has chosen
    • df_button_alerts: How you want to be alerted when you change your dynamic following profile, can be: 'off', 'silent', or 'audible' (default)
    • toyota_distance_btn: Set to True to use the steering wheel distance button on Toyota vehicles to control the dynamic follow profile. Works on TSS2 vehicles and on TSS1 vehicles with an sDSU with a Sep. 2020 firmware or newer.'
    • dynamic_camera_offset: Whether to automatically keep away from oncoming traffic. Works from 35 to ~60 mph
    • dynamic_follow: Deprecated, use the on-screen button to change profiles
  • Experimental params:
    • use_steering_model: A couple of regression models (for TSSP Corolla and TSS2 Camry) were trained to predict torque based on human driving data. By enabling this it tries to extrapolate the model to your PIDF tune using one of the available models. May oscillate on straights.
    • prius_use_pid: This enables the PID lateral controller with new a experimental derivative tune
    • corollaTSS2_use_indi: Enable this to use INDI for lat with your TSS2 Corolla (can be enabled for all years by request)
    • standstill_hack: Some cars support stop and go, you just need to enable this

A full list of parameters that you can modify are located here.

An archive of opParams lives here.

Parameters are stored at /data/op_params.json


opEdit Demo


Automatic updates

When a new update is available on GitHub for Stock Additions, your comma device will pull and reset your local branch to the remote. It then queues a reboot to occur when the following is true:

  • your comma device has been inactive or offroad for more than 5 minutes
  • update_behavior param is set to auto

Therefore, if your device sees an update while you're driving it will reboot approximately 5 to 10 minutes after you finish your drive, it resets the timer if you start driving again before the time is up.


ZSS Support

If you have a Prius with a ZSS (Zorrobyte Steer Sensor), you can use this fork to take full advantage of your high-precision angle sensor! Added support for ZSS with PR #198, there's nothing you need to do. Special thanks to Trae for helping testing the addition!

If you have a ZSS but not a Prius, let me know and I can add support for your car.


Offline crash logging(removed temporarily)

If you experience a crash or exception while driving with this fork, and you're not on internet for the error to be uploaded to Sentry, you should be able to check out the directory /data/community/crashes to see any and all logs of exceptions caught in openpilot. Simply view the logs with ls -lah and then cat the file you wish to view by date. This does not catch all errors, for example scons compilation errors or some Python syntax errors will not be caught, tmux a is usually best to view these (if openpilot didn't start).

Quickly view the latest crash: cat /data/community/crashes/latest.log

Feel free to reach out to me on Discord if you're having any issues with the fork!


Documentation

Quick Installation

To install Stock Additions, just enter the following URL on the setup screen for "Custom Software" after you factory reset:

https://smiskol.com/fork/sshane
  • Or use the emu CLI to easily switch to this fork's default branch: emu fork switch sshane. The initial setup may take longer than the above method, but you gain the ability to quickly switch to any fork you want.

  • Or run the following commands in an ssh terminal on your device:

    cd /data/
    mv openpilot openpilot.old  # or equivalent
    git clone -b SA-master --depth 1 --recurse-submodules https://github.com/sshane/openpilot
    sudo reboot
    

Branches

Most of the branches on this fork are development branches I use as various openpilot tests. The few that more permanent are the following:

  • SA-master: My development branch of Stock Additions I use to test new features or changes; similar to the master branch. Not recommended as a daily driver.
  • SA-release: This is similar to stock openpilot's release branch. Will receive occasional and tested updates to Stock Additions.

Archive Stock Additions branches


Videos

Here's a short video showing how close the traffic profile was in 0.7.4. In 0.7.5, the traffic profile is an average of 7.371 feet closer from 18 mph to 90 mph. Video thanks to @rolo01!


If you'd like to support my development of Stock Additions with a dollar for a RaceTrac ICEE (my PayPal link). Thanks! 🥰

About

DOES NOT SUPPORT COMMA 3X - Stock Additions (0.8.14): 3/automatic following distance profiles, customizable fork params with opEdit, and a smoother longitudinal experience for TSS2 Toyotas

Resources

License

Stars

Watchers

Forks

Sponsor this project

 

Languages

  • Python 53.5%
  • C++ 26.7%
  • C 16.0%
  • Cython 0.9%
  • MATLAB 0.9%
  • Shell 0.9%
  • Other 1.1%