Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CSS for long code blocks #54

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix CSS for long code blocks #54

merged 1 commit into from
Mar 2, 2021

Conversation

staltz
Copy link
Member

@staltz staltz commented Mar 2, 2021

Before

Screenshot from 2021-03-02 16-27-00

After

Screenshot from 2021-03-02 16-29-01

@staltz staltz requested a review from cryptix March 2, 2021 14:30
cryptix
cryptix approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@cryptix cryptix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just saw the last part, I think we can punt on syntax highlighting. There is support for it in blackfriday using chroma but I don't see a real need for it.

@staltz
Copy link
Member Author

staltz commented Mar 2, 2021

Just saw the last part, I think we can punt on syntax highlighting. There is support for it in blackfriday using chroma but I don't see a real need for it.

Oh totally, that was in my example just because I copy pasted from somewhere.

@staltz staltz merged commit be1eae8 into master Mar 2, 2021
@staltz staltz deleted the fix-code-block-wrap branch March 2, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptix cryptix cryptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staltz @cryptix