fix rendering non-members on the dashboard #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doing this in the template was hard to read and inefficient. also: rename OnlineMembers to OnlineUsers since it is a misnomer. There are other connected peers in a room in certain privacy modes.
|
I've deployed this to my instance now and I can't see the dashboard missbehaving anymore. Thanks! |
cblgh
approved these changes
Jun 1, 2021
staltz
reviewed
Jun 1, 2021
| if err != nil { | ||
| // TODO: do we want to show "external users" (non-members) on the dashboard? |
There was a problem hiding this comment.
The answer to that TODO comment apparently is "yes" 😄
staltz
reviewed
Jun 1, 2021
| {{$member = $alias.Name}} | ||
| {{$memberIsAlias = true}} | ||
| {{end}} | ||
| {{end}} |
staltz
approved these changes
Jun 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #236