-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul passwords #211
Overhaul passwords #211
Conversation
Shows a green "this is you" label on the members list. Green because that's also the color of the tag on the top right. Also changes the color of the moderator label from green to blue to be less confusing.
Yep, this is a great idea!
I just had an idea: what if we allow the "username" field to be either the SSB ID or one of the aliases? |
Aaah..! I see, yea that works, too! I like that, will add it to the list. |
remove unsed about page and fix some typos
Lot's of new stuff in here. Did all the things but need to add tests for the new flow. |
4533199
to
ee17a0a
Compare
I was tempted to also add password complexity checks other then length to the server side but would prefer if we add something like zxcvbn to the fronted directly. |
hahaha holy shit that project name is so bad & so good |
I had a hunch it's up your ally... ;) |
also update AuthFallback database * re-write fallback auth to use alias or ssbid * replace Create() with SetPassword() which does an upsert * Add reset tokens to sqlite * add test for SetPassword with reset token
previously it just worked on errors
* reset link creation * own password change * setPasswordWithToken * also: move member handler funcs to own file
6f8d55d
to
7c356fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I didn't test it out in the browser but from the templates I have an imagination of what it looks like. Good that this PR was full stack and had tests too.
TODO
@ssbid || an alias
Update privacy notice to indicate use of HIBP.See Update privacy policy default text #214add label to own entry in members list ( eaaed06 )
Shows a green "this is you" label on the members list. Green because that's also the color of the tag on the top right. Also changes the color of the moderator label from green to blue to be less confusing. (ps: totally open for another color then blue for mods, just didnt want both to be green)
cc @soapdog IIRC you suggested this on our office hour. I really liked the idea.