Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul passwords #211

Merged
merged 9 commits into from
May 14, 2021
Merged

Overhaul passwords #211

merged 9 commits into from
May 14, 2021

Conversation

cryptix
Copy link
Member

@cryptix cryptix commented May 11, 2021

TODO

add label to own entry in members list ( eaaed06 )

Shows a green "this is you" label on the members list. Green because that's also the color of the tag on the top right. Also changes the color of the moderator label from green to blue to be less confusing. (ps: totally open for another color then blue for mods, just didnt want both to be green)

this-is-you

cc @soapdog IIRC you suggested this on our office hour. I really liked the idea.

cryptix added 2 commits May 11, 2021 08:18
Shows a green "this is you" label on the members list. Green because
that's also the color of the tag on the top right.

Also changes the color of the  moderator label from green to blue to be
less confusing.
web/templates/base.tmpl Outdated Show resolved Hide resolved
@staltz
Copy link
Member

staltz commented May 11, 2021

Shows a green "this is you" label on the members list. Green because that's also the color of the tag on the top right. Also changes the color of the moderator label from green to blue to be less confusing. (ps: totally open for another color then blue for mods, just didnt want both to be green)

Yep, this is a great idea!

make it possible to change ones own password

I just had an idea: what if we allow the "username" field to be either the SSB ID or one of the aliases?

@cryptix
Copy link
Member Author

cryptix commented May 11, 2021

what if we allow the "username" field to be either the SSB ID or one of the aliases?

Aaah..! I see, yea that works, too! I like that, will add it to the list.

cryptix added 2 commits May 11, 2021 10:16
remove unsed about page and fix some typos
@cryptix
Copy link
Member Author

cryptix commented May 11, 2021

Lot's of new stuff in here. Did all the things but need to add tests for the new flow.

@cryptix cryptix force-pushed the passwords-overhaul branch from 4533199 to ee17a0a Compare May 12, 2021 06:36
@cryptix
Copy link
Member Author

cryptix commented May 12, 2021

I was tempted to also add password complexity checks other then length to the server side but would prefer if we add something like zxcvbn to the fronted directly.

@cblgh
Copy link
Contributor

cblgh commented May 12, 2021

hahaha holy shit that project name is so bad & so good

cmd/insert-user/main.go Outdated Show resolved Hide resolved
@cryptix
Copy link
Member Author

cryptix commented May 12, 2021

that project name

I had a hunch it's up your ally... ;)

@cryptix cryptix marked this pull request as ready for review May 12, 2021 13:00
cryptix added 4 commits May 13, 2021 07:39
also update AuthFallback database

* re-write fallback auth to use alias or ssbid
* replace Create() with SetPassword() which does an upsert
* Add reset tokens to sqlite
* add test for SetPassword with reset token
previously it just worked on errors
* reset link creation
* own password change
* setPasswordWithToken
* also: move member handler funcs to own file
@cryptix cryptix force-pushed the passwords-overhaul branch from 6f8d55d to 7c356fa Compare May 13, 2021 05:40
@cryptix cryptix mentioned this pull request May 13, 2021
15 tasks
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't test it out in the browser but from the templates I have an imagination of what it looks like. Good that this PR was full stack and had tests too.

@cryptix cryptix merged commit 98c5a59 into master May 14, 2021
@cryptix cryptix deleted the passwords-overhaul branch May 14, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants