Add a test where clients are disconnected forcefully

[cryptix]

This new test is just like the normal make a tunnel through the server with two js clients-test.

The only difference is: just after the tunnel is build and the clients are about to sign off happily, the server cuts the connection (by simply shutting down).

With the bug we isolated in #190, this leads the nodejs processes to exit immediately because of an uncaught throw in pull-stream drain.

To make these tests pass ssb-room-client needs to be patched here to have an extra done callback on the drain call.

Additionally we advise for pull-stream to have a better way of signaling the inability to handle the error then just throwing the error from the network without an indication who called drain without the optional 2nd callback. @staltz gave me this idea and I managed to find the culprit in room-observer.ts with it:

diff --git a/sinks/drain.js b/sinks/drain.js
index 2025462..ef8c6fc 100644
--- a/sinks/drain.js
+++ b/sinks/drain.js
@@ -3,6 +3,11 @@
 module.exports = function drain (op, done) {
   var read, abort
 
+  var causeErr
+  if (typeof done === 'undefined') {
+    causeErr = new Error('no done callback supplied')
+  }
+
   function sink (_read) {
     read = _read
     if(abort) return sink.abort()
@@ -18,8 +23,10 @@ module.exports = function drain (op, done) {
             if(end = end || abort) {
               loop = false
               if(done) done(end === true ? null : end)
-              else if(end && end !== true)
+              else if(end && end !== true) {
+                console.warn(causeErr)
                 throw end
+              }
             }
             else if(op && false === op(data) || abort) {
               loop = false

TODO: publish updated nodejs deps and update our package.json to use them.

[staltz]

I'm working on a fix to ssb-room-client, will let you know when you can update the version here

[staltz]

Ship it

[staltz]

✔️