Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy mode tests 💯 💯 #200

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Privacy mode tests 💯 💯 #200

merged 8 commits into from
Apr 26, 2021

Conversation

cblgh
Copy link
Contributor

@cblgh cblgh commented Apr 26, 2021 •
edited
Loading

This PR implements most of the missing tests of #96; closes #96.

Not implemented: tests for the open mode, because we're lacking anything meaningful on that front as of yet :)

YUP     member cannot create invite
YUP     moderator can create invite
YUP     admin can create invite
YUP     non-members cannot connect to room / finish connection establishment / query room for others??
YUP     alias resolving should not work (returns error if attempted)

community mode:
YUP     member can create invite
YUP     moderator can create invite
YUP     admin can create invite
YUP     non-members can connect to room / conn establishment works

open mode:
can't really test, as we don't have this functinality in other places?

@cblgh cblgh force-pushed the privacy-mode-tests branch from 3bbc7b3 to d9bc17e Compare April 26, 2021 06:31
@cblgh
Copy link
Contributor Author

cblgh commented Apr 26, 2021

honestly no idea why i had to patch d9bc17e, didn't touch anything around aliases other than add tests (the tweak in setup_tests.go? something introduced prior to this PR? wat)

@cblgh cblgh changed the title Privacy mode tests Privacy mode tests 💯 💯 Apr 26, 2021
cryptix
cryptix requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@cryptix cryptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nitpicks then should be good to merge!

roomsrv/init_network.go Show resolved Hide resolved
web/handlers/admin/setup_test.go Outdated Show resolved Hide resolved
@cblgh cblgh force-pushed the privacy-mode-tests branch from f865eb5 to be39596 Compare April 26, 2021 07:26
@cblgh cblgh force-pushed the privacy-mode-tests branch from be39596 to 3651432 Compare April 26, 2021 07:29
@cblgh cblgh merged commit fa6fa32 into master Apr 26, 2021
cryptix
cryptix approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@cryptix cryptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@cblgh cblgh deleted the privacy-mode-tests branch April 26, 2021 08:09
@cryptix cryptix mentioned this pull request Apr 29, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptix cryptix cryptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing privacy modes
2 participants
@cblgh @cryptix