Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename address field in alias JSON resolver #184

Merged
merged 1 commit into from
Apr 22, 2021
Merged

rename address field in alias JSON resolver #184

merged 1 commit into from
Apr 22, 2021

Conversation

staltz
Copy link
Member

@staltz staltz commented Apr 21, 2021

Fixes #183. Turned out the field itself was present, just needed a rename from address to multiserverAddress. And a few more tests.

@staltz staltz requested a review from cryptix April 21, 2021 16:47
cryptix
cryptix approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@cryptix cryptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@cryptix
Copy link
Member

cryptix commented Apr 22, 2021

Merging to deploy the update.

@cryptix cryptix merged commit 5dba245 into master Apr 22, 2021
@cryptix cryptix deleted the fix-183 branch April 22, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptix cryptix cryptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON alias endpoint missing multiserverAddress
2 participants
@staltz @cryptix