web room bridge #17
Merged
web room bridge #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptix
force-pushed
the
web-room-bridge
branch
2 times, most recently
from
7768166 to
4e0577c
Compare
There is a new roomstate package now with a Manager which is shared between muxrpc and the http handler(s). Also adds a list of peers in the room to admin dashboard.
* fix nav link * fix roomstate lock and ticker * fix copy pasta typos web/handlers: stop using /testing/base in news This was a brainfart. The idea for a more minimal base template came from another project with different frontend code. This stopped us from seeing tempalting errors in the nav area. Might want to scratch these tests alltogether and just have one place with all the http tests.
cryptix
force-pushed
the
web-room-bridge
branch
from
346bfa4 to
431e917
Compare
|
the big part of this was beea19f - there now is the roomstate package which implements a Manager, which supplies the following methods: func (m *Manager) AddEndpoint(who refs.FeedRef, edp muxrpc.Endpoint)
func (m *Manager) Has(who refs.FeedRef) (muxrpc.Endpoint, bool)
func (m *Manager) List() []string
func (m *Manager) Register(sink broadcasts.RoomChangeSink)
func (m *Manager) Remove(who refs.FeedRef)Has(ref) can be used to get a muxrpc client to that peer, if it's connected. Right now only List() is used on the dashboard landing page. |
|
Fixes #9 |
staltz
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should show a list of id that are in the room on the dashboard.