Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change withssb login QR code to be a login URL #144

Merged
merged 2 commits into from
Apr 14, 2021
Merged

change withssb login QR code to be a login URL #144

merged 2 commits into from
Apr 14, 2021

Conversation

staltz
Copy link
Member

@staltz staltz commented Apr 13, 2021

Fixes #132

@staltz staltz requested a review from cryptix April 14, 2021 08:15
cryptix
cryptix approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@cryptix cryptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one style nitpick.

web/handlers/auth/withssb.go Outdated Show resolved Hide resolved
@staltz
Copy link
Member Author

staltz commented Apr 14, 2021

Nice, let's merge

@staltz staltz merged commit 919fe51 into master Apr 14, 2021
@staltz staltz deleted the withssb-remotelogin branch April 14, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptix cryptix cryptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssb-http-auth QR Code should contain URL
2 participants
@staltz @cryptix