-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start styling privacy modes ui #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cblgh Good job! I have a few suggested commits for visual tweaks, and a bigger suggestion. Other than that, this looks visually good and the code refactor of admin/dashboard.go
is great.
The bigger suggestion is this: the dashboard page should be reserved for high-level overview of the current state of the room, and most of the time there will be many (or non-zero) peers online, and each of those peers is rendered in a list below the counter. There are plans for making that list dynamic #118, and in that case, this privacy mode UI would jump up and down as peers join and leave, making it difficult to click on the buttons.
So I'd recommend we move all of this new UI to a new page, Settings
, with its own left-side menu item, and for now there would only be the privacy mode setting. Note that this page would have to be guarded for permission access. Members cannot change the privacy mode.
Co-authored-by: André Staltz <[email protected]>
@staltz thanks for the review! :) regarding moving the logic to a separate page due to planned work, i would suggest that can be done when that work is actually in the pipeline? from #118, it seems that might be coming quite a bit down the road (and end up being left on the cutting floor, due to overriding priorities):
if this would have been signaled earlier, i would have taken that into account from the start :~ |
There are 3 reasons why to put it on a separate page: (1) #118, (2) Dashboard is for read-only high-level information, not for configuring the room, (3) room-wide configurations should be available only to admins and mods. You're right that (1) is future work, but (2) and (3) are currently applicable. If you need help, we can merge this PR and I can do this page-moving work if you want.
We could have communicated better, like from my part the spec uses "Dashboard" to mean "all the pages behind a login", while "Dashboard" in this repo is just one page with some counters. |
Alright, well let's merge this then & perform the larger change in a separate PR 👍. Whether you do that or I do it doesn't really matter as much. (Edit: Tracking that as a todo in #134) |
oh ya btw i tottttallly missed the part ranging over the IDs https://github.com/ssb-ngi-pointer/go-ssb-room/blob/ff028699d2cb490bc14f05970bea46260ace00c7/web/templates/admin/dashboard.tmpl#L80-L86 |
mock:
todos: