combine aliases page with members page #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
commented
Apr 7, 2021
cryptix
reviewed
Apr 7, 2021
Co-authored-by: Henry <[email protected]>
|
Can haz merge? (My next PR is building on top of this branch) |
|
purrfect! go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are missing (I'm working on them now), but wanted to submit this already for review of the implementation, and to let @cblgh see the HTML dropdown using
<details>.Desktop
Members page
(notice no Aliases option on the left-side menu)
Member details page
Mobile
Looks good on mobile too, but didn't feel it was necessary to screenshot here.