Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON alias endpoint not working #181

Closed
staltz opened this issue Apr 21, 2021 · 3 comments · Fixed by #182
Closed

JSON alias endpoint not working #181

staltz opened this issue Apr 21, 2021 · 3 comments · Fixed by #182
Labels
Bug Something isn't working Go golang related stuff
Milestone
NGIp milestone

Comments

@staltz
Copy link
Member

staltz commented Apr 21, 2021 •
edited
Loading

This one is easy to test: open this URL https://staltzphone.hermies.club?encoding=json and it should respond with a JSON body.
@staltz staltz added this to the NGIp milestone milestone Apr 21, 2021
@staltz staltz added Bug Something isn't working Go golang related stuff labels Apr 21, 2021
@cryptix
Copy link
Member

cryptix commented Apr 21, 2021

ouch. This slipped through #117 - the alias forwarding wrongly strips the rest of the url

@cryptix
Copy link
Member

cryptix commented Apr 21, 2021

Fixed on the demo server, updating config here now.

cryptix added a commit that referenced this issue Apr 21, 2021
@cryptix
Fix nginx.cfg for alias resolve when using JSON
02303fc 
fixes #181

The location/proxy_pass rule stripped the rest of the request URL.
This makes sure the url arguments are passed on to backend correctly.

See also: https://dev.to/danielkun/nginx-everything-about-proxypass-2ona
@cryptix cryptix mentioned this issue Apr 21, 2021
Merged
@cryptix cryptix closed this as completed Apr 21, 2021
@staltz
Copy link
Member Author

staltz commented Apr 21, 2021

Good! Just one more detail until ssb-room-client consumeAlias works with alice.room.com: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Go golang related stuff
Projects
None yet
Milestone
NGIp milestone
Development

Successfully merging a pull request may close this issue.

Fix nginx.cfg for alias resolve when using JSON ssbc/go-ssb-room
2 participants
@staltz @cryptix