Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Members can create notices #176

Closed
cblgh opened this issue Apr 21, 2021 · 0 comments · Fixed by #207
Closed

Members can create notices #176

cblgh opened this issue Apr 21, 2021 · 0 comments · Fixed by #207
Assignees
@cryptix
Labels
Bug Something isn't working
Milestone
Community launch

Comments

@cblgh
Copy link
Contributor

cblgh commented Apr 21, 2021

I am logged in with a user that has RoleMember, and I try to create a notice. Instead of running into an error, I am able to create the notice.

Even if we disable the UI, I feel this should still be handled by a check in the server as well.
@cblgh cblgh added the Bug Something isn't working label Apr 21, 2021
@cblgh cblgh added this to the Community launch milestone Apr 21, 2021
@cblgh cblgh mentioned this issue Apr 21, 2021
Merged
1 task
@cryptix cryptix mentioned this issue Apr 22, 2021
Closed
16 tasks
@cryptix cryptix self-assigned this May 10, 2021
cryptix added a commit that referenced this issue May 10, 2021
@cryptix
add test for notice creation role check
990ea7e 
updates #176
cryptix added a commit that referenced this issue May 10, 2021
@cryptix
add middleware to check roles
e9ee232 
fixes #176
@cryptix cryptix mentioned this issue May 10, 2021
Merged
cryptix added a commit that referenced this issue May 10, 2021
@cryptix
add test for notice creation role check
691f0e7 
updates #176
cryptix added a commit that referenced this issue May 10, 2021
@cryptix
add middleware to check roles
5385ef6 
fixes #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptix cryptix

Labels
Bug Something isn't working
Projects
None yet
Milestone
Community launch
Development

Successfully merging a pull request may close this issue.

Bugfixing ssbc/go-ssb-room
2 participants
@cryptix @cblgh