To not modify CMAKE_FIND_LIBRARY_PREFIXES and CMAKE_FIND_LIBRARY_SUFF…

…IXES on Windows (gazebosim#189) `CMAKE_FIND_LIBRARY_PREFIXES` and `CMAKE_FIND_LIBRARY_SUFFIXES` are variables that are used by CMake to change the behaviour of the `find_library` call. Changing them to `.lib;.dll` in the CMake config file of every ignition project affect silently any downstream project that calls `find_package(ignition-<pkg>)`, even if transitevely, leading to subtle bugs. Signed-off-by: Silvio <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
srmainwaring · Mar 1, 2022 · ccda2fd · ccda2fd
1 parent e187a09
commit ccda2fd
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/cmake/ignition-config.cmake.in b/cmake/ignition-config.cmake.in
@@ -133,12 +133,6 @@ else()
     INTERFACE_LINK_LIBRARIES "${ign_all_components};@import_target_name@")
 endif()
 
-# On windows we produce .dll libraries with no prefix
-if(WIN32)
-  set(CMAKE_FIND_LIBRARY_PREFIXES "")
-  set(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".dll")
-endif()
-
 # Package variables. Note that @PKG_NAME@_LIBRARIES and @PKG_NAME@_CORE_LIBRARY
 # contain imported targets, so @PKG_NAME@_INCLUDE_DIRS is never needed.
 set(@PKG_NAME@_CORE_LIBRARY @simple_import_name@)