Bump CI build from JDK 19 to 21 (LTS) #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
changed the title
|
Secretly hoping it fixes https://github.com/square/okhttp/actions/runs/7313047455/job/19924201870 and we get off to the new year with clean builds. |
yschimke
added
graal
yschimke
commented
Dec 24, 2023
| @@ -560,7 +561,8 @@ open class HttpUrlTest { | |||
| ']'.code | |||
| ) | |||
| .override( | |||
| Encoding.IDENTITY, | |||
| // java.net.URL got stricter | |||
| if (PlatformVersion.majorVersion >= 21) Encoding.SKIP else Encoding.IDENTITY, | |||
There was a problem hiding this comment.
@swankjesse I'm not sure this is right, is there a better way to make assertions here? That it now fails for URL?
There was a problem hiding this comment.
Lemme attempt a follow-up. I think we need to fix our code.
|
@swankjesse requesting post review. Particularly over how to handle JDK 21 URI strictness. |
|
Landing to get builds green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.