Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with release build & update proguard config. #8156

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Test with release build & update proguard config. #8156

merged 4 commits into from
Dec 23, 2023

Conversation

yschimke
Copy link
Collaborator

Fix for #8154

Keep the DB package name since it's now a literal.

Also add a test of a release build of an app.

@yschimke yschimke requested a review from swankjesse December 23, 2023 12:04
@yschimke yschimke added the android Relates to usage specifically on Android label Dec 23, 2023
@yschimke
Copy link
Collaborator Author

yschimke commented Dec 23, 2023 •
edited
Loading

@swankjesse I'll fix the tests in follow up

Seem regexy, maybe your other change?

https://github.com/square/okhttp/actions/runs/7308237700/job/19914706476#step:8:443

okhttp3.logging.LoggingEventListenerTest > testCacheEvents[test(AVD) - 10] FAILED 
	java.util.regex.PatternSyntaxException: Syntax error in regexp pattern near index 92
	cacheConditionalHit: Response\{protocol=h2, code=200, message=, url=http://localhost:48997/}

Exception thrown during onBeforeAll invocation of plugin com.android.tools.utp.plugins.host.apkinstaller.AndroidTestApkInstallerPlugin.
Failed to install APK(s): /Users/runner/work/okhttp/okhttp/okhttp-android/build/outputs/apk/androidTest/debug/okhttp-android-debug-androidTest.apk
INSTALL_FAILED_DEPRECATED_SDK_VERSION: App package must target at least SDK version 23, but found 21
com.android.ddmlib.InstallException: INSTALL_FAILED_DEPRECATED_SDK_VERSION: App package must target at least SDK version 23, but found 21
	at com.android.ddmlib.internal.DeviceImpl.installRemotePackage(DeviceImpl.java:1409)
	at com.android.ddmlib.internal.DeviceImpl.installPackage(DeviceImpl.java:1235)

JakeWharton
JakeWharton approved these changes Dec 23, 2023
View reviewed changes
android-test-app/src/main/kotlin/okhttp/android/testapp/TestApplication.kt

import android.app.Application

class TestApplication: Application() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added? Seems unneeded.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, but I wanted the full structure. Not sure whether to delete now, might leave and reconsider.

@yschimke
Copy link
Collaborator Author

Will fix those tests in follow ups.

@yschimke yschimke merged commit 265cb04 into square:master Dec 23, 2023
19 of 21 checks passed
This was referenced Dec 23, 2023
Merged
Merged
@yschimke yschimke deleted the release_proguard branch December 24, 2023 06:11
swankjesse
swankjesse reviewed Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvb2060 vvb2060 mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
android Relates to usage specifically on Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yschimke @JakeWharton @swankjesse