Passing keyword only args as positional should fail. #406
Conversation
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c8acb9a of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change c8acb9a: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5337 |
|
tricky, because extremely trivial, yet the backwards compat for a very slow moving project like Mako implies we'd need a major release. waht if we just keep this as an unusual idiosyncratic behavior and just add a test that it passes? |
|
That's fine. Someone just asked about on stackoverflow. Should there be a note in the Using defs part of the documentation or just leave the test as the documentation? |
|
I think adding a doc note is fine, indicating there's a bit of legacy behavior here to be aware of, in addition to a test that notes it's related to issue #405 |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 0ad95a2 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 0ad95a2 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5337 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5337 has been merged. Congratulations! :) |
Issue
#405
This is a backwards incompatible change because code that was "working" will now throw an exception.
Historically related
836e5f9