PR: Test icons for naming changes in QtAwesome #13881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Depends on spyder-ide/qtawesome#155 |
ccordoba12
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Thanks @dalthviz for your prompt response to solve this problem! I left a minor comment, otherwise looks good.
ccordoba12
changed the title
dalthviz
force-pushed
the
qtawesome_support
branch
from
375aad8 to
f320aa9
Compare
ccordoba12
added a commit
that referenced
this pull request
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use QtAwesome master for tests. Add test for the mapping of icons
Issue(s) Resolved
Related to #13858
Related to #13875
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz