CC-26461 Backporting improvements to the password reset workflow #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmiseev
reviewed
Nov 30, 2023
| @@ -505,6 +508,14 @@ public function restorePassword(CustomerTransfer $customerTransfer) | |||
| return $customerResponseTransfer; | |||
| } | |||
|
|
|||
| $customerResponseTransfer = $this | |||
There was a problem hiding this comment.
the test file should be also copied from the original PR (Bundles/Customer/tests/SprykerTest/Zed/Customer/Business/Facade/RestorePasswordTest.php).
There was a problem hiding this comment.
I thought we don't backport tests? 😕
|
Module name in the changelogs is wrong (not a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch: backport/5.51.6
Ticket: https://spryker.atlassian.net/browse/CC-26461
Version: 5.51.6
Release Table
Module Customer
Change log
Improvements
CustomerFacade::restorePassword()with the behavior that customer password resets expire after two hours.CustomerConfig::isCustomerPasswordResetExpirationEnabled(): bool()to enable or disable the reset expiration. It is enabled by default.CustomerConfig::getCustomerPasswordResetExpirationPeriod()to get a DateTime-compatible string to define the expiration threshold. The default is two hours.