Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorWrapper to populate errors for MethodValidationResult #43330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YongGoose
Copy link

resolved #42013

  • Added ErrorWrapper to enable DefaultErrorAttributes to handle errors related to MethodValidationResult.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2024
@YongGoose
Copy link
Author

@wilkinsona @philwebb

If there are any issues with my approach or implementation, I would appreciate your feedback 😁

@philwebb
Copy link
Member

philwebb commented Dec 3, 2024

@YongGoose I think from a cursory glance this is what we had in mind, but we won't be able to do a detailed review until we look at merging the PR. We can't do that until we branch for Spring Boot 3.5 which is still a few weeks away.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 3, 2024
@philwebb philwebb added this to the 3.5.x milestone Dec 3, 2024
@YongGoose
Copy link
Author

@philwebb
Thank you for the detailed explanation!
I'll wait for the branching process for Spring Boot 3.5 and the subsequent review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultErrorAttributes doesn't populate errors for MethodValidationResult
3 participants