Retain quotes on relative URLs in CSS #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssnano's normalizeUrl removes quotes from relative URLs, underminining the fix for spring-io#11 that was made in 8aab4d7. There's no configuration option that I can see on normalizeUrl to disable the removal of quotes, so this commit disables normalizeUrl entirely.
philwebb
pushed a commit
to philwebb/spring-asciidoctor-backends
that referenced
this pull request
Jul 7, 2021
Prior to this commit, we introduced a basic implementation for GraphQL metrics with Spring GraphQL. The main problem was that we were tracking the GraphQL queries themselves and those are good candidates for tags cardinality explosion. This commit revisits the metrics arrangement and introduces: * `graphql.request` as the main metric; this tracks the execution of a single request (i.e. multiple queries) * `graphql.datafetcher` for tracking data fetching operations. * `graphql.error` for counting errors. Closes spring-iogh-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cssnano's normalizeUrl removes quotes from relative URLs, underminining the fix for #11 that was made in 8aab4d7.
There's no configuration option that I can see on normalizeUrl to disable the removal of quotes, so this PR disables normalizeUrl entirely.