Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral Storage Property Missing from 2.9.4 Onwards #500

Open
HyoSang opened this issue Dec 2, 2024 · 1 comment
Open

Ephemeral Storage Property Missing from 2.9.4 Onwards #500

HyoSang opened this issue Dec 2, 2024 · 1 comment
Milestone

Comments

@HyoSang
Copy link

HyoSang commented Dec 2, 2024

Hello,

It seems that the changes from this commit are no longer present starting from the 2.9.4 release.

Currently, this feature is only available in version 2.9.3. As a result, from version 2.9.4 onwards, the ephemeral-storage property cannot be applied to pods.

Could you please investigate and restore this feature?

Thank you!

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Dec 2, 2024
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Dec 2, 2024
Adds missing ephemeral storeagew and hugepages properties.

See spring-cloud#500
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Dec 2, 2024
Adds missing ephemeral storeage and hugepages properties.

See spring-cloud#500
@cppwfs
Copy link
Contributor

cppwfs commented Dec 2, 2024

We will be adding this update to the 3.0.0 release of deployer.

@cppwfs cppwfs removed the status/need-triage Team needs to triage and take a first look label Dec 2, 2024
@cppwfs cppwfs added this to the 3.0.x milestone Dec 2, 2024
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Dec 4, 2024
Removes deprecated methods in relevant files.

See spring-cloud#500
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Dec 4, 2024
cppwfs pushed a commit to cppwfs/spring-cloud-deployer that referenced this issue Dec 17, 2024
See spring-cloud#500

Fix missing ephemeral storeage and hugepages properties.

Fix formatting.

Fix missing ephemeral storeage and hugepages properties.

Revert LimitsResources constructor to deprecated version.

Fix missing ephemeral storeage and hugepages properties.

Revert RequestsResources constructor to previous version and mark as deprecated.

Added extra all args constructors.
Documented and updated gpuVendor usage. According to documentation there is no common format for the gpu vendor string and it has to be provided as needed.

Remove resolve from JFrog-CLI to have it resolve depedencies from settings and pom files

Signed-off-by: Glenn Renfro <[email protected]>

Update gpu based tests in RunAbstractKubernetesDeployerTests

It was determined that our addition of /gpu in limit determination was incorrect.  meaning it is not standard.
The tests were not updated based on this code change.  This commit resolves this

Signed-off-by: Glenn Renfro <[email protected]>

Remove deprecated constructors from KubernetesDeployerProperties.

One deprecation was in error and removed from this PR.
Signed-off-by: Glenn Renfro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants